mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Akhil P Oommen <akhilpo@oss.qualcomm.com>,
	Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
	Imran Shaik <imran.shaik@oss.qualcomm.com>,
	Taniya Das <taniya.das@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: SM8750: Enable CPUFreq support
Date: Wed, 21 Jan 2026 13:52:26 +0100	[thread overview]
Message-ID: <39e2bd90-8566-42d9-8ecd-6c5ba0f9747d@oss.qualcomm.com> (raw)
In-Reply-To: <b98eae93-dae6-4036-90c4-8fc02a122e97@oss.qualcomm.com>

On 1/21/26 1:47 PM, Akhil P Oommen wrote:
> On 1/21/2026 5:06 PM, Konrad Dybcio wrote:
>> On 1/20/26 9:54 PM, Akhil P Oommen wrote:
>>> On 1/20/2026 8:13 PM, Konrad Dybcio wrote:
>>>> On 1/20/26 12:25 PM, Akhil P Oommen wrote:
>>>>> On 1/20/2026 3:44 PM, Konrad Dybcio wrote:
>>>>>> On 1/19/26 8:00 PM, Akhil P Oommen wrote:
>>>>>>> On 12/11/2025 12:32 AM, Jagadeesh Kona wrote:
>>>>>>>> Add the cpucp mailbox, sram and SCMI nodes required to enable
>>>>>>>> the CPUFreq support using the SCMI perf protocol on SM8750 SoCs.
>>>>>>>>
>>>>>>>> Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
>>>>>>>
>>>>>>> Just curious, does this patch enable thermal mitigation for CPU clusters
>>>>>>> too?
>>>>>>
>>>>>> If nothing changed, we have lets-not-explode type mitigations via LMH,
>>>>>> but lets-not-burn-the-user would require a skin temp sensor to be
>>>>>> wired up, which then could be used to enable some cooling action
>>>>>
>>>>> In some chipsets, I have noticed that the gpu cooling device throttles
>>>>> GPU to the lowest OPP even with not-so-heavy GPU workloads, making it
>>>>> unusable-ly slow. My hypothesis was that it was due to unmitigated CPU
>>>>> temperature tripping up GPU Tsens.
>>>>>
>>>>> So, I am wondering if there are any additional CPU cooling related
>>>>> changes required to get a reasonable overall performance under thermal
>>>>> constraints.
>>>>
>>>> Yes, something like the aforementioned skin-temp sensor at least..
>>>
>>> I suppose this sensor is off-chip and slow to react.
>>
>> Yes, this would be placed somewhere on the chassis of the device to
>> reflect the actual temperature that the user could experience (since
>> there are regulations about maximum values of that)
>>
>>>> Today Linux will not throttle the CPUs at all (they're not even declared
>>>> as cooling devices) and we sorta agreed that in general it's a good thing
>>>> (tm), because otherwise we'd be coding in a cooling profile into the SoC
>>>> DTSI without taking into account the cooling capabilities of a given end
>>>> device (i.e. in an extreme case, a PC with SM8650 with a cooler that's
>>>> 3kg of aluminium vs a Steam Frame headset where the SoC is centimeters
>>>> away from your face)
>>>>
>>>> Currently, we have cooling policies for devices with fans and the only
>>>> other action is based on a skin temperature sensor (sc8280xp + x13s).
>>>> Everything else is left up to the LMH defaults. AFAIK work is ongoing to
>>>> create a more informed solution, that would have to (quite obviously)
>>>> live in userland.
>>>
>>> I can understand that the skin-temp based mitigation is influenced by
>>> various design decision outside of the SoC die. But I think there should
>>> an on-chip sensor based mitigation which is fast and usually for a short
>>> duration which helps to avoid extreme temperature or violating the
>>> maximum operating point of the chipset. I guess it should depend only on
>>> the SoC characteristics as it is a last resort. It may be implemented in
>>> SW (like cooling device for Adreno GPU) or in HW. Probably the LMH
>>> hardware you mentioned offers this functionality for CPU clusters. I
>>> have no clue. :(
>>
>> Yes, the CPUs are covered.
> 
> Does this LMH based thermal migitation require any initialization from
> Linux? If yes, could you please share a link to a patch which enables it
> for any recent chipset for my reference?

It used to, see drivers/thermal/qcom/lmh.c

I believe it went away roughly with 8250 where the firmware now takes
care of all that.

FYI I think it first appeared with 8994

Konrad

  reply	other threads:[~2026-01-21 12:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 19:02 [PATCH 0/2] " Jagadeesh Kona
2025-12-10 19:02 ` [PATCH 1/2] dt-bindings: mailbox: qcom: Document SM8750 CPUCP mailbox controller Jagadeesh Kona
2025-12-11 16:57   ` Rob Herring (Arm)
2026-01-18 19:40   ` Jassi Brar
2026-01-20 10:22     ` Krzysztof Kozlowski
2026-01-25  0:47       ` Jassi Brar
2025-12-10 19:02 ` [PATCH 2/2] arm64: dts: qcom: SM8750: Enable CPUFreq support Jagadeesh Kona
2025-12-10 19:22   ` Dmitry Baryshkov
2025-12-11 10:20   ` Abel Vesa
2025-12-16  9:04   ` Sibi Sankar
2025-12-17 12:26   ` Konrad Dybcio
2026-01-19 19:00   ` Akhil P Oommen
2026-01-20 10:14     ` Konrad Dybcio
2026-01-20 11:25       ` Akhil P Oommen
2026-01-20 14:43         ` Konrad Dybcio
2026-01-20 20:54           ` Akhil P Oommen
2026-01-21 11:36             ` Konrad Dybcio
2026-01-21 12:47               ` Akhil P Oommen
2026-01-21 12:52                 ` Konrad Dybcio [this message]
2026-01-05 14:07 ` (subset) [PATCH 0/2] " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39e2bd90-8566-42d9-8ecd-6c5ba0f9747d@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=ajit.pandey@oss.qualcomm.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imran.shaik@oss.qualcomm.com \
    --cc=jagadeesh.kona@oss.qualcomm.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    --cc=taniya.das@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®