* [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
@ 2024-08-06 10:38 Animesh Agarwal
2024-08-06 10:43 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Animesh Agarwal @ 2024-08-06 10:38 UTC (permalink / raw)
Cc: Animesh Agarwal, Daniel Baluta, Wim Van Sebroeck, Guenter Roeck,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
linux-watchdog, devicetree, imx, linux-arm-kernel, linux-kernel
Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema.
This fixes dtbs_check errors.
Cc: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
---
There are 12 similar errors related to this missing property from
different blobs.
./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: watchdog@2ad0000:
Unevaluated properties are not allowed ('big-endian' was unexpected)from
schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#
---
Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
index 36b836d0620c..24d47b1701a7 100644
--- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml
@@ -48,6 +48,8 @@ properties:
clocks:
maxItems: 1
+ big-endian: true
+
fsl,ext-reset-output:
$ref: /schemas/types.yaml#/definitions/flag
description: |
--
2.45.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-08-06 10:38 [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property Animesh Agarwal
@ 2024-08-06 10:43 ` Krzysztof Kozlowski
2024-08-06 15:49 ` Frank Li
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-06 10:43 UTC (permalink / raw)
To: Animesh Agarwal
Cc: Daniel Baluta, Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-watchdog,
devicetree, imx, linux-arm-kernel, linux-kernel
On 06/08/2024 12:38, Animesh Agarwal wrote:
> Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema.
> This fixes dtbs_check errors.
>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> ---
> There are 12 similar errors related to this missing property from
> different blobs.
>
> ./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: watchdog@2ad0000:
> Unevaluated properties are not allowed ('big-endian' was unexpected)from
> schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#
> ---
Not sure if this is correct. I mean, technically it is, but Frank Li was
removing big-endian properties so please choose consistent approach.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-08-06 10:43 ` Krzysztof Kozlowski
@ 2024-08-06 15:49 ` Frank Li
2024-08-06 16:44 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Frank Li @ 2024-08-06 15:49 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Animesh Agarwal, Daniel Baluta, Wim Van Sebroeck, Guenter Roeck,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
linux-watchdog, devicetree, imx, linux-arm-kernel, linux-kernel
On Tue, Aug 06, 2024 at 12:43:07PM +0200, Krzysztof Kozlowski wrote:
> On 06/08/2024 12:38, Animesh Agarwal wrote:
> > Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema.
> > This fixes dtbs_check errors.
> >
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > ---
> > There are 12 similar errors related to this missing property from
> > different blobs.
> >
> > ./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: watchdog@2ad0000:
> > Unevaluated properties are not allowed ('big-endian' was unexpected)from
> > schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#
> > ---
>
> Not sure if this is correct. I mean, technically it is, but Frank Li was
> removing big-endian properties so please choose consistent approach.
drivers/watchdog/imx2_wdt.c never parser big-endian. I suggest remove
big-endian in dts file. I suggest keep big-endian only if it really used.
Frank
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-08-06 15:49 ` Frank Li
@ 2024-08-06 16:44 ` Guenter Roeck
2024-08-14 15:37 ` Frank Li
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2024-08-06 16:44 UTC (permalink / raw)
To: Frank Li, Krzysztof Kozlowski
Cc: Animesh Agarwal, Daniel Baluta, Wim Van Sebroeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-watchdog,
devicetree, imx, linux-arm-kernel, linux-kernel
On 8/6/24 08:49, Frank Li wrote:
> On Tue, Aug 06, 2024 at 12:43:07PM +0200, Krzysztof Kozlowski wrote:
>> On 06/08/2024 12:38, Animesh Agarwal wrote:
>>> Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema.
>>> This fixes dtbs_check errors.
>>>
>>> Cc: Daniel Baluta <daniel.baluta@nxp.com>
>>> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
>>> ---
>>> There are 12 similar errors related to this missing property from
>>> different blobs.
>>>
>>> ./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: watchdog@2ad0000:
>>> Unevaluated properties are not allowed ('big-endian' was unexpected)from
>>> schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#
>>> ---
>>
>> Not sure if this is correct. I mean, technically it is, but Frank Li was
>> removing big-endian properties so please choose consistent approach.
>
> drivers/watchdog/imx2_wdt.c never parser big-endian. I suggest remove
> big-endian in dts file. I suggest keep big-endian only if it really used.
>
Agreed.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-08-06 16:44 ` Guenter Roeck
@ 2024-08-14 15:37 ` Frank Li
2024-08-14 16:27 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Frank Li @ 2024-08-14 15:37 UTC (permalink / raw)
To: Guenter Roeck
Cc: Krzysztof Kozlowski, Animesh Agarwal, Daniel Baluta,
Wim Van Sebroeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
linux-watchdog, devicetree, imx, linux-arm-kernel, linux-kernel
On Tue, Aug 06, 2024 at 09:44:16AM -0700, Guenter Roeck wrote:
> On 8/6/24 08:49, Frank Li wrote:
> > On Tue, Aug 06, 2024 at 12:43:07PM +0200, Krzysztof Kozlowski wrote:
> > > On 06/08/2024 12:38, Animesh Agarwal wrote:
> > > > Add missing big-endian property in watchdog/fsl-imx-wdt.yaml schema.
> > > > This fixes dtbs_check errors.
> > > >
> > > > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > > > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > > > ---
> > > > There are 12 similar errors related to this missing property from
> > > > different blobs.
> > > >
> > > > ./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: watchdog@2ad0000:
> > > > Unevaluated properties are not allowed ('big-endian' was unexpected)from
> > > > schema $id: http://devicetree.org/schemas/watchdog/fsl-imx-wdt.yaml#
> > > > ---
> > >
> > > Not sure if this is correct. I mean, technically it is, but Frank Li was
> > > removing big-endian properties so please choose consistent approach.
> >
> > drivers/watchdog/imx2_wdt.c never parser big-endian. I suggest remove
> > big-endian in dts file. I suggest keep big-endian only if it really used.
> >
After Alexander Stein point out, check spec, and dump watch dog reset value
at ls1043a platform.
0x02A80000: 00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0
It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
to handle endian.
So this change is corret.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> Agreed.
>
> Guenter
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property
2024-08-14 15:37 ` Frank Li
@ 2024-08-14 16:27 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2024-08-14 16:27 UTC (permalink / raw)
To: Frank Li
Cc: Guenter Roeck, Krzysztof Kozlowski, Animesh Agarwal,
Daniel Baluta, Wim Van Sebroeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, linux-watchdog, devicetree, imx,
linux-arm-kernel, linux-kernel
On Wed, Aug 14, 2024 at 12:37 PM Frank Li <Frank.li@nxp.com> wrote:
> After Alexander Stein point out, check spec, and dump watch dog reset value
> at ls1043a platform.
>
> 0x02A80000: 00 30 00 00 00 10 00 04 00 01 00 00 00 00 00 0
>
> It is big-endian. imx2_wdt.c use regmap which call regmap_get_val_endian()
> to handle endian.
>
> So this change is corret.
>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
Shouldn't 'big-endian: true' be conditionally enabled only for the
Layerscape platforms?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-14 16:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-06 10:38 [PATCH] dt-bindings: watchdog: fsl-imx-wdt: Add missing 'big-endian' property Animesh Agarwal
2024-08-06 10:43 ` Krzysztof Kozlowski
2024-08-06 15:49 ` Frank Li
2024-08-06 16:44 ` Guenter Roeck
2024-08-14 15:37 ` Frank Li
2024-08-14 16:27 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®