From: Alan Stern <stern@rowland.harvard.edu>
To: Hardik Gajjar <hgajjar@de.adit-jv.com>
Cc: gregkh@linuxfoundation.org, corbet@lwn.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
erosca@de.adit-jv.com, tj@kernel.org, paulmck@kernel.org,
Martin.Mueller5@de.bosch.com
Subject: Re: [PATCH v3] usb: hub: Add quirk to decrease IN-ep poll interval for Microchip USB491x hub
Date: Fri, 1 Dec 2023 11:13:53 -0500 [thread overview]
Message-ID: <39f334d2-abe6-4b4d-a48c-b22a907c6ea6@rowland.harvard.edu> (raw)
In-Reply-To: <20231201144705.97385-1-hgajjar@de.adit-jv.com>
On Fri, Dec 01, 2023 at 03:47:05PM +0100, Hardik Gajjar wrote:
> There is a potential delay in notifying Linux USB drivers of downstream
> USB bus activity when connecting a high-speed or superSpeed device via the
> Microchip USB491x hub. This delay is due to the fixed bInterval value of
> 12 in the silicon of the Microchip USB491x hub.
>
> Microchip requested to ignore the device descriptor and decrease that
> value to 9 as it was too late to modify that in silicon.
>
> This patch speeds up the USB enummeration process that helps to pass
> Apple Carplay certifications and improve the User experience when utilizing
> the USB device via Microchip Multihost USB491x Hub.
>
> A new hub quirk HUB_QUIRK_REDUCE_FRAME_INTR_BINTERVAL speeds up
> the notification process for Microchip USB491x hub by limiting
> the maximum bInterval value to 9.
>
> Signed-off-by: Hardik Gajjar <hgajjar@de.adit-jv.com>
> ---
> changes since version 1:
> - Move implementation from config.c and quirk.c to hub.c as this is hub
> specific changes.
> - Improve commit message.
> - Link to v1 - https://lore.kernel.org/all/20231123081948.58776-1-hgajjar@de.adit-jv.com/
>
> changes since version 2:
> - Call usb_set_interface after updating the bInterval to Tell the HCD about modification
> - Link to v2 - https://lore.kernel.org/all/20231130084855.119937-1-hgajjar@de.adit-jv.com/
> ---
> drivers/usb/core/hub.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index b4584a0cd484..b5ac29c5f016 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -47,12 +47,18 @@
> #define USB_VENDOR_TEXAS_INSTRUMENTS 0x0451
> #define USB_PRODUCT_TUSB8041_USB3 0x8140
> #define USB_PRODUCT_TUSB8041_USB2 0x8142
> +#define USB_VENDOR_MICROCHIP 0x0424
> +#define USB_PRODUCT_USB4913 0x4913
> +#define USB_PRODUCT_USB4914 0x4914
> +#define USB_PRODUCT_USB4915 0x4915
> #define HUB_QUIRK_CHECK_PORT_AUTOSUSPEND 0x01
> #define HUB_QUIRK_DISABLE_AUTOSUSPEND 0x02
> +#define HUB_QUIRK_REDUCE_FRAME_INTR_BINTERVAL 0x08
Why use 0x08 instead of 0x04?
Alan Stern
next prev parent reply other threads:[~2023-12-01 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 14:47 Hardik Gajjar
2023-12-01 16:13 ` Alan Stern [this message]
2023-12-04 7:02 ` Greg KH
2023-12-04 15:25 ` Hardik Gajjar
2023-12-04 15:44 ` Alan Stern
2023-12-04 7:25 ` Hardik Gajjar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39f334d2-abe6-4b4d-a48c-b22a907c6ea6@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=Martin.Mueller5@de.bosch.com \
--cc=corbet@lwn.net \
--cc=erosca@de.adit-jv.com \
--cc=gregkh@linuxfoundation.org \
--cc=hgajjar@de.adit-jv.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®