From: Alan Stern <stern@rowland.harvard.edu>
To: Hardik Gajjar <hgajjar@de.adit-jv.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
corbet@lwn.net, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, erosca@de.adit-jv.com,
tj@kernel.org, paulmck@kernel.org, Martin.Mueller5@de.bosch.com
Subject: Re: [PATCH v3] usb: hub: Add quirk to decrease IN-ep poll interval for Microchip USB491x hub
Date: Mon, 4 Dec 2023 10:44:57 -0500 [thread overview]
Message-ID: <caa5c2c8-7aa7-4ad0-9ad4-a58d1eceea37@rowland.harvard.edu> (raw)
In-Reply-To: <20231204152543.GA115715@vmlxhi-118.adit-jv.com>
On Mon, Dec 04, 2023 at 04:25:43PM +0100, Hardik Gajjar wrote:
> On Mon, Dec 04, 2023 at 08:02:50AM +0100, Greg KH wrote:
> > And why not use BIT() as that's what these are.
> >
> > thanks,
> >
> > greg k-h
>
> I am considering aligning with existing quirks.
> Is it advisable to use something like HUB_QUIRK_REDUCE_FRAME_INTR_BINTERVAL BIT(2)?
> I'm thinking to submit two patches – one to replace hard values with BIT() in existing quirks and a second patch containing my changes.
That's a good idea.
Alan Stern
next prev parent reply other threads:[~2023-12-04 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 14:47 Hardik Gajjar
2023-12-01 16:13 ` Alan Stern
2023-12-04 7:02 ` Greg KH
2023-12-04 15:25 ` Hardik Gajjar
2023-12-04 15:44 ` Alan Stern [this message]
2023-12-04 7:25 ` Hardik Gajjar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caa5c2c8-7aa7-4ad0-9ad4-a58d1eceea37@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=Martin.Mueller5@de.bosch.com \
--cc=corbet@lwn.net \
--cc=erosca@de.adit-jv.com \
--cc=gregkh@linuxfoundation.org \
--cc=hgajjar@de.adit-jv.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®