2.4.1-pre9 fails to compile drm r128 as module

2.4.1-pre9 fails to compile drm r128 as module

[Albert Cranford]

2.4.1-pre9 changes to drivers/char/drm/drm.h are incorrect.
Please reverse this small change to compile correctly.

r128_drv.c:124: `DRM_IOCTL_R128_PACKET' undeclared here (not in a function)
r128_drv.c:124: nonconstant array index in initializer for `r128_ioctls'
make[3]: *** [r128_drv.o] Error 1
make[2]: *** [_modsubdir_drm] Error 2
make[1]: *** [_modsubdir_char] Error 2

--- linux-2.4.1-pre9/drivers/char/drm/drm.h.orig        Sat Jan 20 00:43:11 2001
+++ linux/drivers/char/drm/drm.h        Sat Jan 20 00:49:17 2001
@@ -382,7 +382,7 @@
 #define DRM_IOCTL_R128_BLIT            DRM_IOW( 0x4c, drm_r128_blit_t)
 #define DRM_IOCTL_R128_DEPTH           DRM_IOW( 0x4d, drm_r128_depth_t)
 #define DRM_IOCTL_R128_STIPPLE         DRM_IOW( 0x4e, drm_r128_stipple_t)
-#define DRM_IOCTL_R128_INDIRECT                DRM_IOWR(0x4f, drm_r128_indirect_t)
+#define DRM_IOCTL_R128_PACKET          DRM_IOWR(0x4f, drm_r128_packet_t)
 
 /* Radeon specific ioctls */
 #define DRM_IOCTL_RADEON_CP_INIT       DRM_IOW( 0x40, drm_radeon_init_t)
-- 
Albert Cranford Deerfield Beach FL USA
ac9410@bellsouth.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: 2.4.1-pre9 fails to compile drm r128 as module

[Linus Torvalds]

On Sat, 20 Jan 2001, Albert Cranford wrote:
>
> 2.4.1-pre9 changes to drivers/char/drm/drm.h are incorrect.
> Please reverse this small change to compile correctly.

Actually, please revert a bit more.

(The XFree86 CVS tree is being silly - they've renamed the ioctl's after
4.0.2 instead of just assigning new numbers. I hope they learn. The radeon
merge got a bit too much merged)

		Linus

----
diff -u --recursive --new-file pre9/linux/drivers/char/drm/drm.h linux/drivers/char/drm/drm.h
--- pre9/linux/drivers/char/drm/drm.h	Fri Jan 19 21:41:07 2001
+++ linux/drivers/char/drm/drm.h	Fri Jan 19 21:38:59 2001
@@ -374,15 +374,14 @@
 #define DRM_IOCTL_R128_CCE_RESET	DRM_IO(  0x43)
 #define DRM_IOCTL_R128_CCE_IDLE		DRM_IO(  0x44)
 #define DRM_IOCTL_R128_RESET		DRM_IO(  0x46)
-#define DRM_IOCTL_R128_FULLSCREEN	DRM_IOW( 0x47, drm_r128_fullscreen_t)
-#define DRM_IOCTL_R128_SWAP		DRM_IO(  0x48)
-#define DRM_IOCTL_R128_CLEAR		DRM_IOW( 0x49, drm_r128_clear_t)
-#define DRM_IOCTL_R128_VERTEX		DRM_IOW( 0x4a, drm_r128_vertex_t)
-#define DRM_IOCTL_R128_INDICES		DRM_IOW( 0x4b, drm_r128_indices_t)
-#define DRM_IOCTL_R128_BLIT		DRM_IOW( 0x4c, drm_r128_blit_t)
-#define DRM_IOCTL_R128_DEPTH		DRM_IOW( 0x4d, drm_r128_depth_t)
-#define DRM_IOCTL_R128_STIPPLE		DRM_IOW( 0x4e, drm_r128_stipple_t)
-#define DRM_IOCTL_R128_INDIRECT		DRM_IOWR(0x4f, drm_r128_indirect_t)
+#define DRM_IOCTL_R128_SWAP		DRM_IO(  0x47)
+#define DRM_IOCTL_R128_CLEAR		DRM_IOW( 0x48, drm_r128_clear_t)
+#define DRM_IOCTL_R128_VERTEX		DRM_IOW( 0x49, drm_r128_vertex_t)
+#define DRM_IOCTL_R128_INDICES		DRM_IOW( 0x4a, drm_r128_indices_t)
+#define DRM_IOCTL_R128_BLIT		DRM_IOW( 0x4b, drm_r128_blit_t)
+#define DRM_IOCTL_R128_DEPTH		DRM_IOW( 0x4c, drm_r128_depth_t)
+#define DRM_IOCTL_R128_STIPPLE		DRM_IOW( 0x4d, drm_r128_stipple_t)
+#define DRM_IOCTL_R128_PACKET		DRM_IOWR(0x4e, drm_r128_packet_t)
 
 /* Radeon specific ioctls */
 #define DRM_IOCTL_RADEON_CP_INIT	DRM_IOW( 0x40, drm_radeon_init_t)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/