mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] natsemi pci_enable_device fixup.
@ 2001-02-07 19:28 davej
  2001-02-07 19:29 ` Jeff Garzik
  0 siblings, 1 reply; 3+ messages in thread
From: davej @ 2001-02-07 19:28 UTC (permalink / raw)
  To: Alan Cox; +Cc: Jeff Garzik, Linux Kernel Mailing List


And they keep on coming.

d.

-- 
| Dave Jones.        http://www.suse.de/~davej
| SuSE Labs

diff -urN --exclude-from=/home/davej/.exclude linux/drivers/net/natsemi.c linux-dj/drivers/net/natsemi.c
--- linux/drivers/net/natsemi.c	Wed Feb  7 12:42:40 2001
+++ linux-dj/drivers/net/natsemi.c	Wed Feb  7 19:24:02 2001
@@ -380,11 +380,13 @@

 	find_cnt++;
 	option = find_cnt < MAX_UNITS ? options[find_cnt] : 0;
+
+	if (pci_enable_device(pdev))
+		return -EIO;
+
 	ioaddr = pci_resource_start(pdev, pcibar);
 	iosize = pci_resource_len(pdev, pcibar);

-	if (pci_enable_device(pdev))
-		return -EIO;
 	if (natsemi_pci_info[chip_idx].flags & PCI_USES_MASTER)
 		pci_set_master(pdev);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] natsemi pci_enable_device fixup.
  2001-02-07 19:28 [PATCH] natsemi pci_enable_device fixup davej
@ 2001-02-07 19:29 ` Jeff Garzik
  0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2001-02-07 19:29 UTC (permalink / raw)
  To: davej; +Cc: Alan Cox, Linux Kernel Mailing List

davej@suse.de wrote:
> 
> And they keep on coming.

If you are so motivated, not all of them are in drivers/net  (though I
-certainly- appreciate the work you are doing here, too)

	Jeff


-- 
Jeff Garzik       | "You see, in this world there's two kinds of
Building 1024     |  people, my friend: Those with loaded guns
MandrakeSoft      |  and those who dig. You dig."  --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] natsemi pci_enable_device fixup.
@ 2001-02-07 19:34 davej
  0 siblings, 0 replies; 3+ messages in thread
From: davej @ 2001-02-07 19:34 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Linux Kernel Mailing List


Jeff Garzik wrote...

> If you are so motivated, not all of them are in drivers/net  (though I
> -certainly- appreciate the work you are doing here, too)

*nod*, I'll move on to another dir after I've finished net/
I just felt in the mood to remove some of the simpler items that
have been on my TODO for a while.

regards,

Dave.

-- 
| Dave Jones.        http://www.suse.de/~davej
| SuSE Labs

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-02-07 19:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-02-07 19:28 [PATCH] natsemi pci_enable_device fixup davej
2001-02-07 19:29 ` Jeff Garzik
2001-02-07 19:34 davej

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®