* small bug/oversight found in 2.4.3
@ 2001-04-15 8:23 Swivel
2001-04-15 8:31 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Swivel @ 2001-04-15 8:23 UTC (permalink / raw)
To: linux-kernel
drivers/char/char.c, line 247
create_proc_read_entry() is called regardless of the definition of
CONFIG_PROC_FS, simply wrap call with #ifdef CONFIG_PROC_FS and #endif.
Cheers,
Vito Caputo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: small bug/oversight found in 2.4.3
2001-04-15 8:23 small bug/oversight found in 2.4.3 Swivel
@ 2001-04-15 8:31 ` Jeff Garzik
2001-04-15 8:47 ` Alexander Viro
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2001-04-15 8:31 UTC (permalink / raw)
To: Swivel; +Cc: linux-kernel
Swivel wrote:
>
> drivers/char/char.c, line 247
> create_proc_read_entry() is called regardless of the definition of
> CONFIG_PROC_FS, simply wrap call with #ifdef CONFIG_PROC_FS and #endif.
create_proc_read_entry exists, as a static inline no-op, without
CONFIG_PROC_FS.
Typically you want to change the driver-local function passed to
create_proc_read_entry to be a static inline no-op for the
!CONFIG_PROC_FS case.
--
Jeff Garzik | "Give a man a fish, and he eats for a day. Teach a
Building 1024 | man to fish, and a US Navy submarine will make sure
MandrakeSoft | he's never hungry again." -- Chris Neufeld
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: small bug/oversight found in 2.4.3
2001-04-15 8:31 ` Jeff Garzik
@ 2001-04-15 8:47 ` Alexander Viro
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Viro @ 2001-04-15 8:47 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Swivel, linux-kernel
On Sun, 15 Apr 2001, Jeff Garzik wrote:
> Swivel wrote:
> >
> > drivers/char/char.c, line 247
> > create_proc_read_entry() is called regardless of the definition of
> > CONFIG_PROC_FS, simply wrap call with #ifdef CONFIG_PROC_FS and #endif.
>
> create_proc_read_entry exists, as a static inline no-op, without
> CONFIG_PROC_FS.
... while drivers/char/char.c doesn't exist at all.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-04-15 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-04-15 8:23 small bug/oversight found in 2.4.3 Swivel
2001-04-15 8:31 ` Jeff Garzik
2001-04-15 8:47 ` Alexander Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®