From: Manfred Spraul <manfred@colorfullife.com>
To: linux-kernel@vger.kernel.org
Cc: torvalds@transmeta.com
Subject: [PATCH, COMPILE-FIX, TYPO] drivers/char/pc110pad.c
Date: Sun, 30 Dec 2001 14:15:56 +0100 [thread overview]
Message-ID: <3C2F138C.63EAAE71@colorfullife.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
pc110pad.c doesn't compile if SMP is enabled. This patch is needed:
<<<<<<
--- 2.5/drivers/char/pc110pad.c Sat Dec 29 19:13:41 2001
+++ build-2.5/drivers/char/pc110pad.c Sun Dec 30 14:02:32 2001
@@ -590,7 +590,7 @@
spin_lock_irqsave(&pc110_lock, flags);
if (!--active_count)
outb(0x30, current_params.io+2); /* switch off
digitiser */
- spin_unlock_irqrestore(&active_lock, flags);
+ spin_unlock_irqrestore(&pc110_lock, flags);
return 0;
}
<<<<<<<<<
The bug was introduced between 2.4.17 and 2.5.1: someone added
spinlocks instead of cli(), without adding his name to the changelog.
--
Manfred
P.S.: Netscape eats space, I've attached is as MIME, too.
[-- Attachment #2: patch-pc110 --]
[-- Type: text/plain, Size: 380 bytes --]
--- 2.5/drivers/char/pc110pad.c Sat Dec 29 19:13:41 2001
+++ build-2.5/drivers/char/pc110pad.c Sun Dec 30 14:02:32 2001
@@ -590,7 +590,7 @@
spin_lock_irqsave(&pc110_lock, flags);
if (!--active_count)
outb(0x30, current_params.io+2); /* switch off digitiser */
- spin_unlock_irqrestore(&active_lock, flags);
+ spin_unlock_irqrestore(&pc110_lock, flags);
return 0;
}
next reply other threads:[~2001-12-30 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-30 13:15 Manfred Spraul [this message]
2001-12-30 13:54 ` Alan Cox
2001-12-30 14:02 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C2F138C.63EAAE71@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®