* [PATCH, COMPILE-FIX, TYPO] drivers/char/pc110pad.c
@ 2001-12-30 13:15 Manfred Spraul
2001-12-30 13:54 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Manfred Spraul @ 2001-12-30 13:15 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
pc110pad.c doesn't compile if SMP is enabled. This patch is needed:
<<<<<<
--- 2.5/drivers/char/pc110pad.c Sat Dec 29 19:13:41 2001
+++ build-2.5/drivers/char/pc110pad.c Sun Dec 30 14:02:32 2001
@@ -590,7 +590,7 @@
spin_lock_irqsave(&pc110_lock, flags);
if (!--active_count)
outb(0x30, current_params.io+2); /* switch off
digitiser */
- spin_unlock_irqrestore(&active_lock, flags);
+ spin_unlock_irqrestore(&pc110_lock, flags);
return 0;
}
<<<<<<<<<
The bug was introduced between 2.4.17 and 2.5.1: someone added
spinlocks instead of cli(), without adding his name to the changelog.
--
Manfred
P.S.: Netscape eats space, I've attached is as MIME, too.
[-- Attachment #2: patch-pc110 --]
[-- Type: text/plain, Size: 380 bytes --]
--- 2.5/drivers/char/pc110pad.c Sat Dec 29 19:13:41 2001
+++ build-2.5/drivers/char/pc110pad.c Sun Dec 30 14:02:32 2001
@@ -590,7 +590,7 @@
spin_lock_irqsave(&pc110_lock, flags);
if (!--active_count)
outb(0x30, current_params.io+2); /* switch off digitiser */
- spin_unlock_irqrestore(&active_lock, flags);
+ spin_unlock_irqrestore(&pc110_lock, flags);
return 0;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH, COMPILE-FIX, TYPO] drivers/char/pc110pad.c
2001-12-30 13:15 [PATCH, COMPILE-FIX, TYPO] drivers/char/pc110pad.c Manfred Spraul
@ 2001-12-30 13:54 ` Alan Cox
2001-12-30 14:02 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2001-12-30 13:54 UTC (permalink / raw)
To: Manfred Spraul; +Cc: linux-kernel, torvalds
> The bug was introduced between 2.4.17 and 2.5.1: someone added
> spinlocks instead of cli(), without adding his name to the changelog.
It was broken as part of the weird cli -> spinlock patch that someone added.
I'd fixed it but there is no SMP PC110 so I never tested that case.
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH, COMPILE-FIX, TYPO] drivers/char/pc110pad.c
2001-12-30 13:54 ` Alan Cox
@ 2001-12-30 14:02 ` Dave Jones
0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2001-12-30 14:02 UTC (permalink / raw)
To: Alan Cox; +Cc: Manfred Spraul, linux-kernel, torvalds
On Sun, 30 Dec 2001, Alan Cox wrote:
> > The bug was introduced between 2.4.17 and 2.5.1: someone added
> > spinlocks instead of cli(), without adding his name to the changelog.
> It was broken as part of the weird cli -> spinlock patch that someone added.
> I'd fixed it but there is no SMP PC110 so I never tested that case.
So someone improved SMP scalability on a driver only
used on hardware which can't do SMP ?
*boggle*
Dave.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2001-12-30 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-12-30 13:15 [PATCH, COMPILE-FIX, TYPO] drivers/char/pc110pad.c Manfred Spraul
2001-12-30 13:54 ` Alan Cox
2001-12-30 14:02 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®