mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Svetoslav Slavtchev <galia@st-peter.stw.uni-erlangen.de>
To: linux-kernel@vger.kernel.org
Subject: [2.5.20]newbee call for help getting lvm working
Date: Thu, 06 Jun 2002 19:02:08 +0200	[thread overview]
Message-ID: <3CFF9590.5030504@st-peter.stw.uni-erlangen.de> (raw)

Hi ,
i was trying to get the patch from Anders Gustafsson working in 2.5.20,
but i'm getting  by compilation:
....
lvm.c: In function `__update_hardsectsize':
lvm.c:2021: warning: implicit declaration of function `get_hardsect_size'
...
and by make modules_install:
...........
depmod: *** Unresolved symbols in 
/lib/modules/2.5.20-dj3-lvm-xfs2/kernel/drivers/md/lvm-mod.o
depmod:         get_hardsect_size
make: *** [_modinst_post] Error 1
............

it seems that this function is disapeared between 2.5.18 and 2.5.20
(the patch from Anders Gustafsson is against 2.5.18)

can smbd please help me to solve this issue

regards

svetljo

the patch : 
http://www.linuxhq.com/kernel/v2.5/unofficial/v2.5.18/patches/lvm-cleanups-2.5.18.patch

and the correspondig text from drivers/md/lvm.c :
..............
static void __update_hardsectsize(kern_lv_t *lv) {
    int le, e;
    int max_hardsectsize = 0, hardsectsize;

    for (le = 0; le < lv->lv_allocated_le; le++) {
        hardsectsize = bdev_hardsect_size(lv->lv_current_pe[le].bdev);
        if (hardsectsize == 0)
            hardsectsize = 512;
        if (hardsectsize > max_hardsectsize)
            max_hardsectsize = hardsectsize;
    }

    /* only perform this operation on active snapshots */
    if ((lv->lv_access & LV_SNAPSHOT) &&
        (lv->lv_status & LV_ACTIVE)) {
        for (e = 0; e < lv->lv_remap_end; e++) {
            hardsectsize =  get_hardsect_size( 
lv->lv_block_exception[e].rdev_new);
            if (hardsectsize == 0)
                hardsectsize = 512;
            if (hardsectsize > max_hardsectsize)
                max_hardsectsize = hardsectsize;
        }
    }
}
............................


             reply	other threads:[~2002-06-06 17:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-06 17:02 Svetoslav Slavtchev [this message]
2002-06-08 22:26 ` Anders Gustafsson
2002-06-09 10:24   ` Svetoslav Slavtchev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CFF9590.5030504@st-peter.stw.uni-erlangen.de \
    --to=galia@st-peter.stw.uni-erlangen.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®