From: Svetoslav Slavtchev <galia@st-peter.stw.uni-erlangen.de>
To: Anders Gustafsson <andersg@0x63.nu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.5.20]newbee call for help getting lvm working
Date: Sun, 09 Jun 2002 12:24:30 +0200 [thread overview]
Message-ID: <3D032CDE.7000307@st-peter.stw.uni-erlangen.de> (raw)
In-Reply-To: <3CFF9590.5030504@st-peter.stw.uni-erlangen.de> <20020608222628.GA10981@h55p111.delphi.afb.lu.se>
Anders Gustafsson wrote:
>On Thu, Jun 06, 2002 at 07:02:08PM +0200, Svetoslav Slavtchev wrote:
>
>
>>Hi ,
>>i was trying to get the patch from Anders Gustafsson working in 2.5.20,
>>but i'm getting by compilation:
>>....
>>lvm.c: In function `__update_hardsectsize':
>>lvm.c:2021: warning: implicit declaration of function `get_hardsect_size'
>>
>>
>
>
>[.. snip ..]
>
>
>
>> /* only perform this operation on active snapshots */
>> if ((lv->lv_access & LV_SNAPSHOT) &&
>> (lv->lv_status & LV_ACTIVE)) {
>> for (e = 0; e < lv->lv_remap_end; e++) {
>> hardsectsize = get_hardsect_size(
>>lv->lv_block_exception[e].rdev_new);
>>
>>
>
>snapshotting doesn't work anyhow, so this block could be removed 'til
>its unbroked.
>
thanks, i had a similar solution , but i wasn't shure
i'll try it with a 2.5.20-dj3 or dj4
--- linux-2.5.18/drivers/md/lvm.c 2002-06-04 17:25:40.000000000 +0200
+++ linux-2.5.20-dj3-lvm-xfs-w3/drivers/md/lvm.c 2002-06-08
19:08:41.000000000 +0200
@@ -216,6 +216,7 @@
#include <linux/stat.h>
#include <linux/fs.h>
#include <linux/proc_fs.h>
+#include <linux/buffer_head.h> /* for invalidate_buffers */
#include <linux/blkdev.h>
#include <linux/genhd.h>
#include <linux/devfs_fs_kernel.h>
@@ -2014,17 +2015,23 @@
max_hardsectsize = hardsectsize;
}
+
+ /* FROM ME SVETLJO, otherweise it doesnt compile
+ * get_hardsect_size had disapeared in 2.5.18
+ */
/* only perform this operation on active snapshots */
- if ((lv->lv_access & LV_SNAPSHOT) &&
+/* if ((lv->lv_access & LV_SNAPSHOT) &&
(lv->lv_status & LV_ACTIVE)) {
for (e = 0; e < lv->lv_remap_end; e++) {
- hardsectsize = get_hardsect_size(
lv->lv_block_exception[e].rdev_new);
+ hardsectsize = get_hardsect_size(
lv->lv_block_exception[e].rdev_new);
if (hardsectsize == 0)
hardsectsize = 512;
if (hardsectsize > max_hardsectsize)
max_hardsectsize = hardsectsize;
}
}
+*/
+
}
/*
prev parent reply other threads:[~2002-06-09 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-06 17:02 Svetoslav Slavtchev
2002-06-08 22:26 ` Anders Gustafsson
2002-06-09 10:24 ` Svetoslav Slavtchev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D032CDE.7000307@st-peter.stw.uni-erlangen.de \
--to=galia@st-peter.stw.uni-erlangen.de \
--cc=andersg@0x63.nu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®