mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Almeida <daniel.almeida@collabora.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Andreas Hindborg" <a.hindborg@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: add a ring buffer implementation
Date: Mon, 16 Feb 2026 09:43:25 -0300	[thread overview]
Message-ID: <3D30E044-445A-4260-8409-903D0FD60C7B@collabora.com> (raw)
In-Reply-To: <aZMMyJofDKualqXw@google.com>




> On 16 Feb 2026, at 09:26, Alice Ryhl <aliceryhl@google.com> wrote:
> 
> On Sun, Feb 15, 2026 at 09:24:59PM +0100, Andreas Hindborg wrote:
>> Add a fixed-capacity FIFO ring buffer. The implementation uses a circular
>> buffer with head and tail pointers, providing constant-time push and pop
>> operations.
>> 
>> The module includes a few tests covering basic operations, wrap-around
>> behavior, interleaved push/pop sequences, and edge cases such as
>> single-capacity buffers.
>> 
>> Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
> 
> Why call this ringbuffer instead of matching the stdlib name for the
> same collection? VecDeque.
> 
> And a more general question .. is there any chance we could avoid
> rolling our own for this? Is there an impl in the kernel we could take?
> Or could we vendor code from stdlib?
> 

Well, a pretty good reason is matching this with IoCapable as I suggested. This is also a pretty strong argument against VecDeque, since this is now unrelated to Vec itself.

— Daniel

  reply	other threads:[~2026-02-16 12:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-15 20:24 Andreas Hindborg
2026-02-16  4:35 ` Daniel Almeida
2026-02-16  7:11   ` Andreas Hindborg
2026-02-16 11:44     ` Daniel Almeida
2026-02-16 12:25 ` Alice Ryhl
2026-02-16 12:43   ` Daniel Almeida [this message]
2026-02-16 13:27   ` Andreas Hindborg
2026-02-16 13:45     ` Daniel Almeida
2026-02-16 14:06       ` Danilo Krummrich
2026-02-16 14:21         ` Daniel Almeida
2026-02-16 14:39           ` Danilo Krummrich
2026-02-16 14:46             ` Daniel Almeida
2026-02-17 10:02               ` Andreas Hindborg
2026-02-17 14:26                 ` Danilo Krummrich
2026-02-17 19:10                   ` Andreas Hindborg
2026-02-17 19:25                     ` Daniel Almeida
2026-02-18  8:29                     ` Alice Ryhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D30E044-445A-4260-8409-903D0FD60C7B@collabora.com \
    --to=daniel.almeida@collabora.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®