From: Daniel Almeida <daniel.almeida@collabora.com>
To: Andreas Hindborg <a.hindborg@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: add a ring buffer implementation
Date: Mon, 16 Feb 2026 08:44:10 -0300 [thread overview]
Message-ID: <425CCCE6-4FBF-40F6-AC50-F9D3D536CE50@collabora.com> (raw)
In-Reply-To: <87ikbxduxy.fsf@t14s.mail-host-address-is-not-set>
> On 16 Feb 2026, at 04:14, Andreas Hindborg <a.hindborg@kernel.org> wrote:
>
> "Daniel Almeida" <daniel.almeida@collabora.com> writes:
>
>> Hi Andreas,
>>
>
> <cut>
>
>>
>> (sorry for the formatting, replying from my phone)
>>
>> We should probably make the backing memory configurable from the get go instead of hardcoding KVec. It will be cumbersome to retrofit this change later on, IMHO. I assume that others agree?
>>
>> For example, we can immediately use this in Tyr if you let the backing memory be a mapped GEM object. Having it be DMA memory is probably also going to be useful for others.
>
> It should at least take flags.
>
> iQe can make the backing completely configurable. We could have an
> unsafe initializer that require just a pointer and size at the lowest
> level. The current version is using array indexing to access the memory.
> We could overlay a mutable slice on the pointer and continue using array
> accesses. Or we could change it to just pointer offset calculations, but
> that seems less idea.
>
>
> Best regards,
> Andreas Hindborg
>
Consider adding a second generic parameter with a bound on IoCapable. This is probably what we what here. This will let us delegate the memory accesses to the underlying IoCapable implementation.
— Daniel
next prev parent reply other threads:[~2026-02-16 11:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 20:24 Andreas Hindborg
2026-02-16 4:35 ` Daniel Almeida
2026-02-16 7:11 ` Andreas Hindborg
2026-02-16 11:44 ` Daniel Almeida [this message]
2026-02-16 12:25 ` Alice Ryhl
2026-02-16 12:43 ` Daniel Almeida
2026-02-16 13:27 ` Andreas Hindborg
2026-02-16 13:45 ` Daniel Almeida
2026-02-16 14:06 ` Danilo Krummrich
2026-02-16 14:21 ` Daniel Almeida
2026-02-16 14:39 ` Danilo Krummrich
2026-02-16 14:46 ` Daniel Almeida
2026-02-17 10:02 ` Andreas Hindborg
2026-02-17 14:26 ` Danilo Krummrich
2026-02-17 19:10 ` Andreas Hindborg
2026-02-17 19:25 ` Daniel Almeida
2026-02-18 8:29 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=425CCCE6-4FBF-40F6-AC50-F9D3D536CE50@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®