From: David Glance <david@csse.uwa.edu.au>
To: linux-kernel@vger.kernel.org
Cc: fisaksen@bewan.com, Greg KH <greg@kroah.com>
Subject: Re: PATCH: usb-uhci: interrupt out with urb->interval 0
Date: Sun, 20 Apr 2003 16:08:53 +0800 [thread overview]
Message-ID: <3EA25595.9000001@csse.uwa.edu.au> (raw)
I am not subscribed to this list - please include me on the
'cc' line.
Version: 2.4.21-pre6
Subsystem: USB
Driver: Lego USB Tower
Writing one-short interrupt out transfers without this patch
cause the system to hang. Applying this patch fixes that
(thankfully after fsck'ing my disk a dozen times!) - however
the driver (which works still using usb-ohci on an ohci
card) - doesn't work because the reads are failing -
returning a ETIMEDOUT.
I am assuming that the changes made (see below) - somehow
have affected other aspects of one-shot interrupt in transfers?
Thanks
David
Frode wrote:
A recent change (2.4.21) in the usb-uhci driver calls
"uhci_clean_iso_step2" after the completion of one-shot
(urb->interval
0) interrupt out transfers. This call clears the list of
descriptors.
However, it crashes when trying to get the next desciptor in
the "for"
loop in the "process_interrupt" function, since the list of
descriptors
are already cleared. A simple change I did was to do a
"break" to quit
the "for" loop for interrupt out transfers with urb->interval 0.
Thanks,
Frode
--- drivers/usb/usb-uhci.c.orig 2003-04-16
15:39:04.000000000 +0200
+++ drivers/usb/usb-uhci.c 2003-04-16 15:39:56.000000000 +0200
@@ -2628,6 +2628,7 @@
// correct toggle after
unlink
usb_dotoggle (urb->dev,
usb_pipeendpoint (urb->pipe), usb_pipeout
(urb->pipe));
clr_td_ioc(desc); //
inactivate TD
+ break;
}
}
}
next reply other threads:[~2003-04-20 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-20 8:08 David Glance [this message]
2003-04-20 13:32 ` David Glance
-- strict thread matches above, loose matches on Subject: below --
2003-04-17 8:31 Frode Isaksen
2003-04-18 7:05 ` Greg KH
2003-04-17 7:20 Frode Isaksen
2003-04-16 15:44 Frode Isaksen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EA25595.9000001@csse.uwa.edu.au \
--to=david@csse.uwa.edu.au \
--cc=fisaksen@bewan.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®