mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frode Isaksen <fisaksen@bewan.com>
To: greg@kroah.com
Cc: linux-kernel@vger.kernel.org, weissg@vienna.at
Subject: PATCH: usb-uhci: interrupt out with urb->interval 0
Date: Thu, 17 Apr 2003 10:31:18 +0200	[thread overview]
Message-ID: <F628F73A-70AE-11D7-8F05-003065EF6010@bewan.com> (raw)

A recent change (2.4.21) in the usb-uhci driver calls 
"uhci_clean_iso_step2" after the completion of one-shot (urb->interval 
0) interrupt out transfers. This call clears the list of descriptors. 
However, it crashes when trying to get the next desciptor in the "for" 
loop in the "process_interrupt" function, since the list of descriptors 
are already cleared. A simple change I did was to do a "break" to quit 
the "for" loop for interrupt out transfers with urb->interval 0.

Thanks,
Frode

--- drivers/usb/usb-uhci.c.orig	2003-04-16 15:39:04.000000000 +0200
+++ drivers/usb/usb-uhci.c	2003-04-16 15:39:56.000000000 +0200
@@ -2628,6 +2628,7 @@
  				// correct toggle after unlink
  				usb_dotoggle (urb->dev, usb_pipeendpoint (urb->pipe), usb_pipeout 
(urb->pipe));
  				clr_td_ioc(desc); // inactivate TD
+				break;
  			}
  		}
  	}


             reply	other threads:[~2003-04-17  8:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-17  8:31 Frode Isaksen [this message]
2003-04-18  7:05 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2003-04-20  8:08 David Glance
2003-04-20 13:32 ` David Glance
2003-04-17  7:20 Frode Isaksen
2003-04-16 15:44 Frode Isaksen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F628F73A-70AE-11D7-8F05-003065EF6010@bewan.com \
    --to=fisaksen@bewan.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=weissg@vienna.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®