From: "Javier González" <jg@lightnvm.io>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: "Hans Holmberg" <hans.ml.holmberg@owltronix.com>,
"Matias Bjørling" <mb@lightnvm.io>,
linux-block@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Hans Holmberg" <hans.holmberg@cnexlabs.com>
Subject: Re: [PATCH] lightnvm: pblk: remove spinlock when freeing line metadata
Date: Fri, 6 Oct 2017 15:28:44 +0200 [thread overview]
Message-ID: <3ECEB320-3133-4E85-90EA-1F8AAD597ED6@lightnvm.io> (raw)
In-Reply-To: <7960b012-1154-fdad-0c45-c952357f13f5@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
> On 6 Oct 2017, at 11.20, Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
>
> On 10/05/2017 11:35 AM, Hans Holmberg wrote:
>> From: Hans Holmberg <hans.holmberg@cnexlabs.com>
>>
>> Lockdep complains about being in atomic context while freeing line
>> metadata - and rightly so as we take a spinlock and end up calling
>> vfree that might sleep(in pblk_mfree).
>>
>> There is no need for holding the line manager free_lock while
>> freeing line metadata, so remove the lock.
>>
>> Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
>
> Reviewed-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
>
> I guess this also deserves stable tag. The bug was introduced in 4.13 by
> commit 588726d3ec68 ("lightnvm: pblk: fail gracefully on irrec. error").
>
Good point. We'll add it when picking it up.
Thanks,
Javier
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-10-06 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 8:35 Hans Holmberg
2017-10-06 9:20 ` Andrey Ryabinin
2017-10-06 13:28 ` Javier González [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ECEB320-3133-4E85-90EA-1F8AAD597ED6@lightnvm.io \
--to=jg@lightnvm.io \
--cc=aryabinin@virtuozzo.com \
--cc=hans.holmberg@cnexlabs.com \
--cc=hans.ml.holmberg@owltronix.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®