mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Hans Holmberg <hans.ml.holmberg@owltronix.com>,
	Matias Bjorling <mb@lightnvm.io>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Javier Gonzales <jg@lightnvm.io>,
	Hans Holmberg <hans.holmberg@cnexlabs.com>
Subject: Re: [PATCH] lightnvm: pblk: remove spinlock when freeing line metadata
Date: Fri, 6 Oct 2017 12:20:56 +0300	[thread overview]
Message-ID: <7960b012-1154-fdad-0c45-c952357f13f5@virtuozzo.com> (raw)
In-Reply-To: <1507192546-12156-1-git-send-email-hans.ml.holmberg@owltronix.com>

On 10/05/2017 11:35 AM, Hans Holmberg wrote:
> From: Hans Holmberg <hans.holmberg@cnexlabs.com>
> 
> Lockdep complains about being in atomic context while freeing line
> metadata - and rightly so as we take a spinlock and end up calling
> vfree that might sleep(in pblk_mfree).
> 
> There is no need for holding the line manager free_lock while
> freeing line metadata, so remove the lock.
> 
> Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>

Reviewed-by: Andrey Ryabinin <aryabinin@virtuozzo.com>

I guess this also deserves stable tag. The bug was introduced in 4.13 by
commit 588726d3ec68 ("lightnvm: pblk: fail gracefully on irrec. error").


> ---
> This patch is for:
> https://github.com/OpenChannelSSD/linux branch for-4.15/pblk
> 
>  drivers/lightnvm/pblk-init.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
> index c452478..a645117 100644
> --- a/drivers/lightnvm/pblk-init.c
> +++ b/drivers/lightnvm/pblk-init.c
> @@ -393,13 +393,11 @@ static void pblk_line_meta_free(struct pblk *pblk)
>  	kfree(l_mg->bb_aux);
>  	kfree(l_mg->vsc_list);
>  
> -	spin_lock(&l_mg->free_lock);
>  	for (i = 0; i < PBLK_DATA_LINES; i++) {
>  		kfree(l_mg->sline_meta[i]);
>  		pblk_mfree(l_mg->eline_meta[i]->buf, l_mg->emeta_alloc_type);
>  		kfree(l_mg->eline_meta[i]);
>  	}
> -	spin_unlock(&l_mg->free_lock);
>  
>  	kfree(pblk->lines);
>  }
> 

  reply	other threads:[~2017-10-06  9:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05  8:35 Hans Holmberg
2017-10-06  9:20 ` Andrey Ryabinin [this message]
2017-10-06 13:28   ` Javier González

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7960b012-1154-fdad-0c45-c952357f13f5@virtuozzo.com \
    --to=aryabinin@virtuozzo.com \
    --cc=hans.holmberg@cnexlabs.com \
    --cc=hans.ml.holmberg@owltronix.com \
    --cc=jg@lightnvm.io \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mb@lightnvm.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®