Re:[PATCH, 2.6.0-test11] more correct get_compat_timespec interface

Re:[PATCH, 2.6.0-test11] more correct get_compat_timespec interface

[Jon Foster]

Hi,

 >-int put_compat_timespec(struct timespec *ts, struct compat_timespec *cts)
 >+int put_compat_timespec(struct timespec *ts, const struct 
compat_timespec *cts)
 >{
 >return (verify_area(VERIFY_WRITE, cts, sizeof(*cts)) ||
 >__put_user(ts->tv_sec, &cts->tv_sec) ||

Shouldn't the "const" be on the other argument?

Kind regards,

Jon Foster

Re: [PATCH, 2.6.0-test11] more correct get_compat_timespec interface

[Joe Korty]

On Wed, Dec 03, 2003 at 06:51:19PM +0000, Jon Foster wrote:
>-int put_compat_timespec(struct timespec *ts, struct compat_timespec *cts)
>+int put_compat_timespec(struct timespec *ts, const struct compat_timespec *cts)
> 
> Shouldn't the "const" be on the other argument?

Indeed it should.  Here is the new and improved version, also with '__user' added
at the correct spots.

Regards,
Joe


diff -ura 2.6.0-test11-base/include/linux/compat.h 2.6.0-test11-new/include/linux/compat.h
--- 2.6.0-test11-base/include/linux/compat.h	2003-11-26 15:43:56.000000000 -0500
+++ 2.6.0-test11-new/include/linux/compat.h	2003-12-03 16:04:17.000000000 -0500
@@ -44,8 +44,8 @@
 } compat_sigset_t;
 
 extern int cp_compat_stat(struct kstat *, struct compat_stat *);
-extern int get_compat_timespec(struct timespec *, struct compat_timespec *);
-extern int put_compat_timespec(struct timespec *, struct compat_timespec *);
+extern int get_compat_timespec(struct timespec *, const struct compat_timespec __user *);
+extern int put_compat_timespec(const struct timespec *, struct compat_timespec __user *);
 
 struct compat_iovec {
 	compat_uptr_t	iov_base;
diff -ura 2.6.0-test11-base/kernel/compat.c 2.6.0-test11-new/kernel/compat.c
--- 2.6.0-test11-base/kernel/compat.c	2003-11-26 15:44:11.000000000 -0500
+++ 2.6.0-test11-new/kernel/compat.c	2003-12-03 16:04:17.000000000 -0500
@@ -22,14 +22,14 @@
 
 #include <asm/uaccess.h>
 
-int get_compat_timespec(struct timespec *ts, struct compat_timespec *cts)
+int get_compat_timespec(struct timespec *ts, const struct compat_timespec __user *cts)
 {
 	return (verify_area(VERIFY_READ, cts, sizeof(*cts)) ||
 			__get_user(ts->tv_sec, &cts->tv_sec) ||
 			__get_user(ts->tv_nsec, &cts->tv_nsec)) ? -EFAULT : 0;
 }
 
-int put_compat_timespec(struct timespec *ts, struct compat_timespec *cts)
+int put_compat_timespec(const struct timespec *ts, struct compat_timespec __user *cts)
 {
 	return (verify_area(VERIFY_WRITE, cts, sizeof(*cts)) ||
 			__put_user(ts->tv_sec, &cts->tv_sec) ||