From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] ASoC: qcom: lpass-va-macro: Add shikra compatible
Date: Tue, 9 Jun 2026 11:15:11 +0200 [thread overview]
Message-ID: <3a0890b2-f9c3-439b-a392-fd13e3da850d@oss.qualcomm.com> (raw)
In-Reply-To: <20260608172023.2965292-4-mohammad.rafi.shaik@oss.qualcomm.com>
On 6/8/26 7:20 PM, Mohammad Rafi Shaik wrote:
> Add shikra specific VA macro data and register programming needed by
> the LPASS codec v4.0 implementation.
>
> This adds a shikra regmap/default table covering the ADPT register
> range, wires new match data flags (bypass FS control and ADPT block
> presence), and enables the ADPT control programming path during TX
> decimator bring-up.
>
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> ---
[...]
> +/* ADPT control registers - Shikra adaptive filter blocks */
> +#define CDC_VA_CDC_ADPT0_ADPT_CTRL (0x0800)
> +#define CDC_VA_CDC_ADPT0_ADPT_GAIN_0 (0x0804)
> +#define CDC_VA_CDC_ADPT0_ADPT_GAIN_1 (0x0808)
> +#define CDC_VA_CDC_ADPT0_DH_FSM_CTRL (0x080C)
> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_0 (0x0810)
> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_1 (0x0814)
> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_2 (0x0818)
> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_3 (0x081C)
> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_4 (0x0820)
> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_5 (0x0824)
Please use lowercase hex and drop the parentheses
[...]
> +static const struct reg_default va_shikra_defaults[] = {
> + /* VA macro */
> + { CDC_VA_CLK_RST_CTRL_MCLK_CONTROL, 0x00},
> + { CDC_VA_CLK_RST_CTRL_FS_CNT_CONTROL, 0x00},
> + { CDC_VA_CLK_RST_CTRL_SWR_CONTROL, 0x00},
lowercase hex likewise, please keep a consistent space before the closing
curly bracket
[...]
> + if (va->bypass_fs_control)
> + regmap_update_bits(regmap, CDC_VA_CLK_RST_CTRL_FS_CNT_CONTROL,
> + 0x80, 0x80);
regmap_set_bits()
[...]
> case SND_SOC_DAPM_POST_PMU:
> + if (va->has_adpt_block)
> + snd_soc_component_update_bits(comp, adapt_ctrl, 0xFF, 0x00);
Can you define these magic numbers?
[...]
> + va->regmap = devm_regmap_init_mmio(dev, base,
> + data->regmap_config ? data->regmap_config
> + : &va_regmap_config);
data->regmap_config ?: &va_regmap_config
Konrad
next prev parent reply other threads:[~2026-06-09 9:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 17:20 [PATCH v1 0/3] ASoC: qcom: Add shikra LPASS RX/VA macro support Mohammad Rafi Shaik
2026-06-08 17:20 ` [PATCH v1 1/3] ASoC: dt-bindings: qcom: Add Shikra rx and va macro codecs Mohammad Rafi Shaik
2026-06-09 7:26 ` Krzysztof Kozlowski
2026-06-29 4:45 ` Mohammad Rafi Shaik
2026-06-08 17:20 ` [PATCH v1 2/3] ASoC: qcom: lpass-rx-macro: Add shikra compatible Mohammad Rafi Shaik
2026-06-09 7:28 ` Krzysztof Kozlowski
2026-06-29 4:51 ` Mohammad Rafi Shaik
2026-06-09 9:11 ` Konrad Dybcio
2026-06-29 5:00 ` Mohammad Rafi Shaik
2026-06-08 17:20 ` [PATCH v1 3/3] ASoC: qcom: lpass-va-macro: " Mohammad Rafi Shaik
2026-06-09 9:15 ` Konrad Dybcio [this message]
2026-06-29 5:03 ` Mohammad Rafi Shaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a0890b2-f9c3-439b-a392-fd13e3da850d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®