From: Michal Simek <michal.simek@xilinx.com>
To: netdev@vger.kernel.org
Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>,
monstr@monstr.eu, "Fabian Frederick" <fabf@skynet.be>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Manuel Schölling" <manuel.schoelling@gmx.de>,
"Julia Lawall" <julia.lawall@lip6.fr>,
"Markus Elfring" <elfring@users.sourceforge.net>,
"Subbaraya Sundeep Bhatta" <subbaraya.sundeep.bhatta@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] net: ll_temac: Use one return statement instead of two
Date: Mon, 11 May 2015 16:05:02 +0200 [thread overview]
Message-ID: <3a0fa74dd703db5dac4816ef15b6a512ef0f2ec0.1431353091.git.michal.simek@xilinx.com> (raw)
Use one return statement instead of two to simplify the code.
Both are returning the same value.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Changes in v2:
- Use the same SoB as sender address - Reported-by: Julia Lawall
drivers/net/ethernet/xilinx/ll_temac_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 062483f334a5..cfb6bdb37fdc 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -688,10 +688,8 @@ static int temac_start_xmit(struct sk_buff *skb, struct net_device *ndev)
cur_p = &lp->tx_bd_v[lp->tx_bd_tail];
if (temac_check_tx_bd_space(lp, num_frag)) {
- if (!netif_queue_stopped(ndev)) {
+ if (!netif_queue_stopped(ndev))
netif_stop_queue(ndev);
- return NETDEV_TX_BUSY;
- }
return NETDEV_TX_BUSY;
}
--
2.3.5
next reply other threads:[~2015-05-11 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 14:05 Michal Simek [this message]
2015-05-11 14:42 ` Joe Perches
2015-05-11 15:26 ` Michal Simek
2015-05-11 15:39 ` Joe Perches
2015-05-11 15:44 ` Michal Simek
2015-05-11 15:48 ` Julia Lawall
2015-05-11 16:00 ` Joe Perches
2015-05-12 5:23 ` Julia Lawall
2015-05-11 16:10 ` Joe Perches
2015-05-11 16:12 ` Michal Simek
2015-05-11 15:42 ` Julia Lawall
2015-05-11 18:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a0fa74dd703db5dac4816ef15b6a512ef0f2ec0.1431353091.git.michal.simek@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=fabf@skynet.be \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.schoelling@gmx.de \
--cc=monstr@monstr.eu \
--cc=netdev@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=subbaraya.sundeep.bhatta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®