mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] nvmem: qfprom: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
@ 2022-04-11  1:40 cgel.zte
  2022-04-29  9:27 ` Srinivas Kandagatla
  0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-11  1:40 UTC (permalink / raw)
  To: srinivas.kandagatla; +Cc: linux-kernel, Minghao Chi, Zeal Robot

From: Minghao Chi <chi.minghao@zte.com.cn>

Using pm_runtime_resume_and_get is more appropriate
for simplifing code

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 drivers/nvmem/qfprom.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index 162132c7dab9..c1e893c8a247 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -217,9 +217,8 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
 		goto err_clk_rate_set;
 	}
 
-	ret = pm_runtime_get_sync(priv->dev);
+	ret = pm_runtime_resume_and_get(priv->dev);
 	if (ret < 0) {
-		pm_runtime_put_noidle(priv->dev);
 		dev_err(priv->dev, "Failed to enable power-domain\n");
 		goto err_reg_enable;
 	}
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] nvmem: qfprom: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
  2022-04-11  1:40 [PATCH] nvmem: qfprom: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
@ 2022-04-29  9:27 ` Srinivas Kandagatla
  0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2022-04-29  9:27 UTC (permalink / raw)
  To: cgel.zte; +Cc: linux-kernel, Minghao Chi, Zeal Robot



On 11/04/2022 02:40, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Applied thanks,

--srini
> ---
>   drivers/nvmem/qfprom.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> index 162132c7dab9..c1e893c8a247 100644
> --- a/drivers/nvmem/qfprom.c
> +++ b/drivers/nvmem/qfprom.c
> @@ -217,9 +217,8 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
>   		goto err_clk_rate_set;
>   	}
>   
> -	ret = pm_runtime_get_sync(priv->dev);
> +	ret = pm_runtime_resume_and_get(priv->dev);
>   	if (ret < 0) {
> -		pm_runtime_put_noidle(priv->dev);
>   		dev_err(priv->dev, "Failed to enable power-domain\n");
>   		goto err_reg_enable;
>   	}

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-29  9:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11  1:40 [PATCH] nvmem: qfprom: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
2022-04-29  9:27 ` Srinivas Kandagatla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®