From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Yeoreum Yun <yeoreum.yun@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>, Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <liam@infradead.org>,
Nico Pache <nico.pache@linux.dev>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>, Lance Yang <lance.yang@linux.dev>,
Usama Arif <usama.arif@linux.dev>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Kevin Brodsky <kevin.brodsky@arm.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] kselftest: mm: replace usage of /proc/self/smaps for check_huge_xxx() helper
Date: Thu, 10 Sep 2026 13:27:41 +0200 [thread overview]
Message-ID: <3aad90e1-5081-4f8d-803e-e9f593ce581d@kernel.org> (raw)
In-Reply-To: <aqKTkkK0wnm6cqpX@e129823.arm.com>
On 9/10/26 13:25, Yeoreum Yun wrote:
>> On 9/10/26 12:54, Yeoreum Yun wrote:
>>>
>>> Agree. but there seems the case where discern whethr the mapping is
>>> with regular file or shmem like tmpfs -- khugepaged test where using
>>> __shmem_ops. So I think it would be better to keep this as-is.
>>
>> Let's not add or maintain unnecessary complexity.
>>
>> hmem_check_huge can really just become check_huge_file.
>>
>> Even file_check_huge can just be simplified.
>>
>> There must be a pretty good reason why we'd want to keep this.
>
> Okay. then I'll change the check_huge_shmem() to check_huge_file()
> with the separate patch.
You'll likely have to make both behave the same under the hood first to then
remove check_huge_shmem().
--
Cheers,
David
next prev parent reply other threads:[~2026-09-10 11:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 8:19 [PATCH v5 0/3] kselftest: mm: fix some failure of split_huge_page_test Yeoreum Yun
2026-09-07 8:19 ` [PATCH v5 1/3] kselftest: mm: prevent random failure of huge page split for khugepaged Yeoreum Yun
2026-09-10 10:15 ` David Hildenbrand (Arm)
2026-09-07 8:19 ` [PATCH v5 2/3] kselftest: mm: replace usage of /proc/self/smaps for check_huge_xxx() helper Yeoreum Yun
2026-09-10 10:20 ` David Hildenbrand (Arm)
2026-09-10 10:54 ` Yeoreum Yun
2026-09-10 10:59 ` David Hildenbrand (Arm)
2026-09-10 11:25 ` Yeoreum Yun
2026-09-10 11:27 ` David Hildenbrand (Arm) [this message]
2026-09-10 11:31 ` Yeoreum Yun
2026-09-07 8:19 ` [PATCH v5 3/3] kselftest: mm: introduce alloc_isolated_mem() Yeoreum Yun
2026-09-10 10:34 ` David Hildenbrand (Arm)
2026-09-10 11:02 ` Yeoreum Yun
2026-09-10 11:14 ` David Hildenbrand (Arm)
2026-09-10 11:22 ` Yeoreum Yun
2026-09-10 11:24 ` David Hildenbrand (Arm)
2026-09-10 11:30 ` Yeoreum Yun
2026-09-10 11:55 ` David Hildenbrand (Arm)
2026-09-10 12:16 ` Yeoreum Yun
2026-09-10 12:22 ` Yeoreum Yun
2026-09-10 12:25 ` David Hildenbrand (Arm)
2026-09-10 12:34 ` Yeoreum Yun
2026-09-10 13:14 ` David Hildenbrand (Arm)
2026-09-10 13:52 ` ;, Re: ;, [PATCH v5 3/3] kselftest: ;, mm: introducealloc_isolated_mem; Yeoreum Yun
2026-09-10 10:15 ` [PATCH v5 0/3] kselftest: mm: fix some failure of split_huge_page_test David Hildenbrand (Arm)
2026-09-10 10:31 ` Yeoreum Yun
2026-09-10 10:45 ` David Hildenbrand (Arm)
2026-09-10 11:16 ` Yeoreum Yun
2026-09-10 11:23 ` David Hildenbrand (Arm)
2026-09-10 11:35 ` Yeoreum Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aad90e1-5081-4f8d-803e-e9f593ce581d@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=kevin.brodsky@arm.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=nico.pache@linux.dev \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=yeoreum.yun@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®