From: "Arnd Bergmann" <arnd@arndb.de>
To: "Akshay Gupta" <akshay.gupta@amd.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Guenter Roeck" <linux@roeck-us.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
shyam-sundar.s-k@amd.com, gautham.shenoy@amd.com,
"Mario Limonciello" <mario.limonciello@amd.com>,
naveenkrishna.chatradhi@amd.com, anand.umarji@amd.com
Subject: Re: [PATCH v6 08/11] misc: amd-sbi: Add support for CPUID protocol
Date: Mon, 24 Mar 2025 16:29:20 +0100 [thread overview]
Message-ID: <3ab1116b-7021-4d83-847d-fdec53af9bee@app.fastmail.com> (raw)
In-Reply-To: <20250324145815.1026314-9-akshay.gupta@amd.com>
On Mon, Mar 24, 2025, at 15:58, Akshay Gupta wrote:
> struct apml_message {
> /*
> * [0]...[3] mailbox 32bit input
> + * cpuid,
> + * [4][5] cpuid: thread
> + * [6] cpuid: ext function & read eax/ebx or ecx/edx
> + * [7:0] -> bits [7:4] -> ext function &
> + * bit [0] read eax/ebx or ecx/edx
> * [7] read/write functionality
> */
> union {
> + __u64 cpu_msr_in;
> __u32 mb_in[2];
> __u8 reg_in[8];
> } data_in;
This changes the alignment of the structure and makes
it incompatible between 32-bit and 64-bit userspace
when there is an odd number of 32-bit words in it.
Arnd
next prev parent reply other threads:[~2025-03-24 15:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 14:58 [PATCH v6 00/11] misc: Move AMD side band interface(SBI) functionality Akshay Gupta
2025-03-24 14:58 ` [PATCH v6 01/11] hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc Akshay Gupta
2025-03-24 14:58 ` [PATCH v6 02/11] misc: amd-sbi: Move protocol functionality to core file Akshay Gupta
2025-03-24 14:58 ` [PATCH v6 03/11] misc: amd-sbi: Move hwmon device sensor as separate entity Akshay Gupta
2025-03-24 14:58 ` [PATCH v6 04/11] misc: amd-sbi: Use regmap subsystem Akshay Gupta
2025-03-24 14:58 ` [PATCH v6 05/11] misc: amd-sbi: Optimize the wait condition for mailbox command completion Akshay Gupta
2025-03-24 14:58 ` [PATCH v6 06/11] misc: amd-sbi: Add support for AMD_SBI IOCTL Akshay Gupta
2025-03-24 15:40 ` Arnd Bergmann
2025-03-25 12:35 ` Gupta, Akshay
2025-03-25 13:37 ` Arnd Bergmann
2025-03-26 11:46 ` Gupta, Akshay
2025-03-24 14:58 ` [PATCH v6 07/11] misc: amd-sbi: Add support for mailbox error codes Akshay Gupta
2025-03-24 15:26 ` Arnd Bergmann
2025-03-25 12:35 ` Gupta, Akshay
2025-03-24 14:58 ` [PATCH v6 08/11] misc: amd-sbi: Add support for CPUID protocol Akshay Gupta
2025-03-24 15:29 ` Arnd Bergmann [this message]
2025-03-25 12:35 ` Gupta, Akshay
2025-03-24 14:58 ` [PATCH v6 09/11] misc: amd-sbi: Add support for read MCA register protocol Akshay Gupta
2025-03-24 14:58 ` [PATCH v6 10/11] misc: amd-sbi: Add support for register xfer Akshay Gupta
2025-03-24 14:58 ` [PATCH v6 11/11] misc: amd-sbi: Add document for AMD SB IOCTL description Akshay Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ab1116b-7021-4d83-847d-fdec53af9bee@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akshay.gupta@amd.com \
--cc=anand.umarji@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mario.limonciello@amd.com \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=shyam-sundar.s-k@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®