mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hin-Tak Leung <hintak.leung@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, Greg KH <greg@kroah.com>,
	Eric Valette <eric.valette@free.fr>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [RFT] rtl8187: use DMA-aware buffers with usb_control_msg
Date: Sat, 9 May 2009 00:20:19 +0100	[thread overview]
Message-ID: <3ace41890905081620h10d0250eq1ede9cd73021dc5b@mail.gmail.com> (raw)
In-Reply-To: <1241632963-25601-1-git-send-email-linville@tuxdriver.com>

On Wed, May 6, 2009 at 7:02 PM, John W. Linville <linville@tuxdriver.com> wrote:
> This definitely needs to fail more gracefully in the event of a
> kmalloc failure...
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>

I am  using this patch with compat-wireless with
2.6.29.2-134.fc11.x86_64 - presumably one needs to be using 2.6.30-rcX
to see any problems?

We mostly inherited that code concerned (and its style) from the vendor driver.

On Wed, May 6, 2009 at 7:45 AM, Greg KH <greg@kroah.com> wrote:

> Also it looks like rtl8225_write_8051() is incorrect.  You are passing a
> pointer to a variable that was passed as an argument.  I don't know
> where that is supposed to be on, somewhere on the stack I guess.
>
> Larry, care to fix this up?

I think John's patch resolves this issue to the extent it can -
rtl8225_write_8051() is called by rtl8225_write() which in turns gets
its input mostly in the form of magic contants (except a few
instances). So allocating a buffer and copying the magic contants in,
just before calling usb_control_msg() seems an acceptable way forward?

Hin-Tak

  reply	other threads:[~2009-05-08 23:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-03 15:36 DMA debug trace pointing to rtl8187 Eric Valette
2009-05-06  4:30 ` FUJITA Tomonori
2009-05-06  5:21   ` Greg KH
2009-05-06  6:35   ` Eric Valette
2009-05-06  6:45     ` Greg KH
2009-05-06 18:02       ` [RFT] rtl8187: use DMA-aware buffers with usb_control_msg John W. Linville
2009-05-08 23:20         ` Hin-Tak Leung [this message]
2009-05-09  9:38           ` Eric Valette
2009-05-09 13:57             ` Greg KH
2009-05-09 15:50               ` John W. Linville
2009-05-09 16:35                 ` Greg KH
2009-05-09 21:24                 ` Larry Finger
2009-05-11 13:20                   ` John W. Linville
2009-05-11 22:23                     ` Hin-Tak Leung
2009-05-06 18:03       ` DMA debug trace pointing to rtl8187 John W. Linville
2009-05-09 17:29       ` Larry Finger
2009-05-09 17:46         ` Eric Valette
2009-05-09 19:22           ` Eric Valette
2009-05-09 19:29         ` Greg KH
2009-05-09 20:19           ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ace41890905081620h10d0250eq1ede9cd73021dc5b@mail.gmail.com \
    --to=hintak.leung@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=eric.valette@free.fr \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®