Re: [RFT] rtl8187: use DMA-aware buffers with usb_control_msg

[Hin-Tak Leung <hintak.leung@gmail.com>]

On Mon, May 11, 2009 at 2:20 PM, John W. Linville
<linville@tuxdriver.com> wrote:
> On Sat, May 09, 2009 at 04:24:21PM -0500, Larry Finger wrote:
>> John W. Linville wrote:
>> >
>> > Yeah, I don't like the original version either.  Even if the kmalloc's
>> > aren't a big performance hit, the failure path sucks.  I've included a
>> > new version below, but unfortunately I haven't had a chance to test it.
>> > Please give it a try if you get a chance?
>>
>> This one tests just fine here running on the latest pull of wireless testing
>> (v2.6.30-rc4-22732-gd879ac6). I think there is a leak of priv->io_dmabuf when
>> the driver is unloaded, and kfree(priv->io_dmabuf) should be added to
>> rtl8187_disconnect(). Otherwise ACK.
>
> Doh!
>
> ---
>
> From dbc8e19329b52c53832cbb03eea76646e44aab07 Mon Sep 17 00:00:00 2001
> From: John W. Linville <linville@tuxdriver.com>
> Date: Wed, 6 May 2009 13:57:27 -0400
> Subject: [PATCH] rtl8187: use DMA-aware buffers with usb_control_msg
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>

This looks so much cleaner. ACK - I see you already checked this in to
wireless-testing. Tried to give it a go just now, but got bitten by
the wext key management change, I think.

Hin-Tak