From: Randy Dunlap <rdunlap@infradead.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
Bragatheswaran Manickavel <bragathemanick0908@gmail.com>,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: fix doc warnings related to drm connector
Date: Sat, 9 Sep 2023 20:59:21 -0700 [thread overview]
Message-ID: <3ae5be2b-8075-5a4d-65c7-7282a44909f3@infradead.org> (raw)
In-Reply-To: <ZP0-DaW3lIeaZ8xY@debian.me>
On 9/9/23 20:54, Bagas Sanjaya wrote:
> On Sat, Sep 09, 2023 at 04:33:43PM +0530, Bragatheswaran Manickavel wrote:
>> Addressing drm dp/hdmi connector related kernel documentation
>> warning and add more information about these values.
>
> What are these?
>
There are already patches for these issues.
Please check latest linux-next and make patches to it instead of using mainline.
Thanks.
>>
>> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
>> ---
>> drivers/gpu/drm/drm_connector.c | 2 ++
>> include/drm/drm_connector.h | 2 ++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
>> index bf8371dc2a61..084c95785dda 100644
>> --- a/drivers/gpu/drm/drm_connector.c
>> +++ b/drivers/gpu/drm/drm_connector.c
>> @@ -2203,6 +2203,7 @@ static int drm_mode_create_colorspace_property(struct drm_connector *connector,
>> /**
>> * drm_mode_create_hdmi_colorspace_property - create hdmi colorspace property
>> * @connector: connector to create the Colorspace property on.
>> + * @supported_colorspaces: to get hdmi supported colorspaces.
>> *
>> * Called by a driver the first time it's needed, must be attached to desired
>> * HDMI connectors.
>> @@ -2227,6 +2228,7 @@ EXPORT_SYMBOL(drm_mode_create_hdmi_colorspace_property);
>> /**
>> * drm_mode_create_dp_colorspace_property - create dp colorspace property
>> * @connector: connector to create the Colorspace property on.
>> + * @supported_colorspaces: to get dp supported colorspaces.
>> *
>> * Called by a driver the first time it's needed, must be attached to desired
>> * DP connectors.
>> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
>> index d300fde6c1a4..556d66dd122c 100644
>> --- a/include/drm/drm_connector.h
>> +++ b/include/drm/drm_connector.h
>> @@ -498,6 +498,8 @@ enum drm_privacy_screen_status {
>> * ITU-R BT.601 colorimetry format
>> * The DP spec does not say whether this is the 525 or the 625
>> * line version.
>> + * @DRM_MODE_COLORIMETRY_COUNT:
>> + * Represents the count of colorspaces.
>> */
>> enum drm_colorspace {
>> /* For Default case, driver will set the colorspace */
>
> Oh, you mean to add description for colorspace-related fields.
>
> Thanks.
>
>
--
~Randy
next prev parent reply other threads:[~2023-09-10 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 11:03 Bragatheswaran Manickavel
2023-09-10 3:54 ` Bagas Sanjaya
2023-09-10 3:59 ` Randy Dunlap [this message]
[not found] ` <CAHZF+VZLB5h0HY2voHaMmkWsd_okTSP2svgNetNPJWG0MX9Gew@mail.gmail.com>
2023-09-10 19:11 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ae5be2b-8075-5a4d-65c7-7282a44909f3@infradead.org \
--to=rdunlap@infradead.org \
--cc=airlied@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=bragathemanick0908@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®