mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yanteng Si <siyanteng@loongson.cn>
To: Dongliang Mu <dzm91@hust.edu.cn>,
	Jonathan Corbet <corbet@lwn.net>,
	Cheng Ziqiu <chengziqiu@hust.edu.cn>, Alex Shi <alexs@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] scripts: fix most issues reported by pylint
Date: Mon, 17 Jun 2024 10:29:04 +0800	[thread overview]
Message-ID: <3ae5e014-108e-484e-bbdf-689ab67a85e2@loongson.cn> (raw)
In-Reply-To: <4df7cbfd-5a14-43a4-973b-23fd4f5d78fb@hust.edu.cn>

Hi,Dongliang

在 2024/6/17 09:05, Dongliang Mu 写道:
>
> On 2024/6/16 03:42, Jonathan Corbet wrote:
>> Dongliang Mu <dzm91@hust.edu.cn> writes:
>>
>>> Pylint reports many coding style issues of scripts/checktransupdate.py
>>>
>>> This patch fixes most issues with the following contents:
>>> - add or revise comments for all functions
>>> - use format string suggested by python
>>>
>>> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
>>> ---
>>>   scripts/checktransupdate.py | 55 
>>> ++++++++++++++++---------------------
>>>   1 file changed, 24 insertions(+), 31 deletions(-)
>> How does this differ from v1?  Please always give that information so
>> reviewers know what's going on.
>
> Hi Jon,
>
> Patch 1/2 in v2 patch has no difference with Patch 1/2 in v1. Randy 
> put up some change requests about
>
> the help documentation, and it is written in the Patch 2/2 in v2.
>
> I am not sure how to show this information in Patch 1/2. How about 
> "v1->v2: no changes"?
>
>
Let's make a cover letter, just like:

<https://lore.kernel.org/netdev/cover.1716973237.git.siyanteng@loongson.cn/>


you can run:


$: git format-patch xxxxx   --cover-letter


BTW,

It seem that you forget to cc  linux-doc@vger.kernel.org.


Thanks,

Yanteng


  reply	other threads:[~2024-06-17  2:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-15  3:53 Dongliang Mu
2024-06-15  3:53 ` [PATCH v2 2/2] doc-guide: add help documentation checktransupdate.rst Dongliang Mu
2024-06-15  7:57   ` si.yanteng
2024-06-15  8:24     ` Dongliang Mu
2024-06-17  8:06   ` Jani Nikula
2024-06-17 10:45     ` Dongliang Mu
2024-06-15 19:42 ` [PATCH v2 1/2] scripts: fix most issues reported by pylint Jonathan Corbet
2024-06-17  1:05   ` Dongliang Mu
2024-06-17  2:29     ` Yanteng Si [this message]
2024-06-17  2:43       ` Dongliang Mu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ae5e014-108e-484e-bbdf-689ab67a85e2@loongson.cn \
    --to=siyanteng@loongson.cn \
    --cc=alexs@kernel.org \
    --cc=chengziqiu@hust.edu.cn \
    --cc=corbet@lwn.net \
    --cc=dzm91@hust.edu.cn \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®