From: Dongliang Mu <dzm91@hust.edu.cn>
To: Jonathan Corbet <corbet@lwn.net>,
Cheng Ziqiu <chengziqiu@hust.edu.cn>,
Yanteng Si <siyanteng@loongson.cn>, Alex Shi <alexs@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] scripts: fix most issues reported by pylint
Date: Mon, 17 Jun 2024 09:05:53 +0800 [thread overview]
Message-ID: <4df7cbfd-5a14-43a4-973b-23fd4f5d78fb@hust.edu.cn> (raw)
In-Reply-To: <87ikyakn6l.fsf@trenco.lwn.net>
On 2024/6/16 03:42, Jonathan Corbet wrote:
> Dongliang Mu <dzm91@hust.edu.cn> writes:
>
>> Pylint reports many coding style issues of scripts/checktransupdate.py
>>
>> This patch fixes most issues with the following contents:
>> - add or revise comments for all functions
>> - use format string suggested by python
>>
>> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
>> ---
>> scripts/checktransupdate.py | 55 ++++++++++++++++---------------------
>> 1 file changed, 24 insertions(+), 31 deletions(-)
> How does this differ from v1? Please always give that information so
> reviewers know what's going on.
Hi Jon,
Patch 1/2 in v2 patch has no difference with Patch 1/2 in v1. Randy put
up some change requests about
the help documentation, and it is written in the Patch 2/2 in v2.
I am not sure how to show this information in Patch 1/2. How about
"v1->v2: no changes"?
Dongliang Mu
>
> Thanks,
>
> jon
next prev parent reply other threads:[~2024-06-17 1:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-15 3:53 Dongliang Mu
2024-06-15 3:53 ` [PATCH v2 2/2] doc-guide: add help documentation checktransupdate.rst Dongliang Mu
2024-06-15 7:57 ` si.yanteng
2024-06-15 8:24 ` Dongliang Mu
2024-06-17 8:06 ` Jani Nikula
2024-06-17 10:45 ` Dongliang Mu
2024-06-15 19:42 ` [PATCH v2 1/2] scripts: fix most issues reported by pylint Jonathan Corbet
2024-06-17 1:05 ` Dongliang Mu [this message]
2024-06-17 2:29 ` Yanteng Si
2024-06-17 2:43 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4df7cbfd-5a14-43a4-973b-23fd4f5d78fb@hust.edu.cn \
--to=dzm91@hust.edu.cn \
--cc=alexs@kernel.org \
--cc=chengziqiu@hust.edu.cn \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®