From: Andrew Lunn <andrew@lunn.ch>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Po-Yu Chuang <ratbert@faraday-tech.com>,
Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"taoren@meta.com" <taoren@meta.com>
Subject: Re: [PATCH net-next v4 4/4] net: ftgmac100: Add RGMII delay support for AST2600
Date: Wed, 12 Nov 2025 14:19:31 +0100 [thread overview]
Message-ID: <3af52caa-88a7-4b88-bd92-fd47421cc81a@lunn.ch> (raw)
In-Reply-To: <SEYPR06MB5134EBA2235B3D4BE39B19359DCCA@SEYPR06MB5134.apcprd06.prod.outlook.com>
> > This is an optional property. If it does not exist, you have an old DT blob. It is
> > not an error. So you need to do different things depending on what the error
> > code is. If it does not exist, just return 0 and leave the hardware alone. If it is
> > some other error report it, and abort the probe.
> >
>
> Based on this for next version, I want to move the "aspeed,scu" from dtsi to dts.
> Change it to optional and accord it whether existed to decide it is old or new DT
> blob.
I think that is the easy way out, not necessarily the correct way.
All systems have the aspeed,scu, so it should really be in the .dtsi
file.
What are you really trying to solve? That the DT blob says "rgmii",
but the bootloader has configured the MAC to add delays? You should be
able to test for that condition. If it is found, issue as warning, and
treat phy-mode as 'rgmii-id'. If the DT blob says 'rgmii-id' and the
MAC is configured to add the delays, the system is at least
consistent, no need for a warning, disable the MAC delays and pass
_RGMII_ID to the PHY. And if the blob says 'rgmii-id' and the MAC is
not adding delays, no need to touch the MAC delay, and pass _RGMII_ID
to the PHY.
Are there any mainline DT .dts files which say rgmii-txid, or
rgmii-rxid? They would be rather odd, but occasionally you see them.
Assuming there are not lots of them, i would probably just leave
everything as is.
Andrew
next prev parent reply other threads:[~2025-11-12 13:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 11:09 [PATCH net-next v4 0/4] Add AST2600 RGMII delay into ftgmac100 Jacky Chou
2025-11-10 11:09 ` [PATCH net-next v4 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600 Jacky Chou
2025-11-10 12:29 ` Rob Herring (Arm)
2025-11-10 15:21 ` Andrew Lunn
2025-11-11 3:09 ` Jacky Chou
2025-11-10 11:09 ` [PATCH net-next v4 2/4] ARM: dts: aspeed-g6: Add scu and rgmii delay value per step for MAC Jacky Chou
2025-11-10 11:09 ` [PATCH net-next v4 3/4] ARM: dts: aspeed: ast2600-evb: Configure RGMII delay " Jacky Chou
2025-11-10 11:09 ` [PATCH net-next v4 4/4] net: ftgmac100: Add RGMII delay support for AST2600 Jacky Chou
2025-11-10 15:35 ` Andrew Lunn
2025-11-12 3:45 ` Jacky Chou
2025-11-12 13:19 ` Andrew Lunn [this message]
2025-11-13 10:40 ` Jacky Chou
2025-11-15 21:46 ` Andrew Lunn
2025-11-25 2:58 ` Jacky Chou
2025-11-25 23:49 ` Andrew Lunn
2025-11-26 8:57 ` Tao Ren
2025-11-27 8:47 ` Jacky Chou
2025-12-02 6:53 ` Jacky Chou
2025-12-02 13:36 ` Andrew Lunn
2025-12-03 5:30 ` Jacky Chou
2025-11-10 15:45 ` Andrew Lunn
2025-11-10 14:34 ` [PATCH net-next v4 0/4] Add AST2600 RGMII delay into ftgmac100 Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3af52caa-88a7-4b88-bd92-fd47421cc81a@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jacky_chou@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ratbert@faraday-tech.com \
--cc=robh@kernel.org \
--cc=taoren@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®