[PATCH 0/2] Fix compile warnings for SM8550 and SM8650

[PATCH 0/2] Fix compile warnings for SM8550 and SM8650

[Krishna Kurapati]

arch/arm64/boot/dts/qcom/sm8550.dtsi:4133.22-4223.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property

arch/arm64/boot/dts/qcom/sm8650.dtsi:5086.22-5177.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property

Fix them up accordingly.

This series has only been compile tested.

Krishna Kurapati (2):
  arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node
  arm64: dts: qcom: sm8650: Fix compile warnings in USB controller node

 arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 --
 arch/arm64/boot/dts/qcom/sm8650.dtsi | 3 ---
 2 files changed, 5 deletions(-)

-- 
2.34.1

[PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node

[Krishna Kurapati]

With W=1, the following error comes up:

Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property

This is because the child node being removed during flattening and moving
to latest bindings.

Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 2ca9e50ef599..e3f93f4f412d 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -4133,8 +4133,6 @@ usb_dp_qmpphy_dp_in: endpoint {
 		usb_1: usb@a600000 {
 			compatible = "qcom,sm8550-dwc3", "qcom,snps-dwc3";
 			reg = <0x0 0x0a600000 0x0 0xfc100>;
-			#address-cells = <1>;
-			#size-cells = <0>;
 
 			clocks = <&gcc GCC_CFG_NOC_USB3_PRIM_AXI_CLK>,
 				 <&gcc GCC_USB30_PRIM_MASTER_CLK>,
-- 
2.34.1

[PATCH 2/2] arm64: dts: qcom: sm8650: Fix compile warnings in USB controller node

[Krishna Kurapati]

With W=1, the following error comes up:

Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property

This is because the child node being removed during flattening and moving
to latest bindings.

Fixes: 77e1f16b9302 ("arm64: dts: qcom: sm8650: Flatten the USB nodes")
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8650.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index 07ae74851621..f8e1950a74ac 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -5150,9 +5150,6 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 
 			dma-coherent;
 
-			#address-cells = <1>;
-			#size-cells = <0>;
-
 			status = "disabled";
 
 			ports {
-- 
2.34.1

Re: [PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node

[Krzysztof Kozlowski]

On 03/12/2025 15:48, Krishna Kurapati wrote:
> With W=1, the following error comes up:
> 
> Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
> 
> This is because the child node being removed during flattening and moving
> to latest bindings.
> 
> Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")


I don't fully understand that original commit - it explicitly changed
address/size-cells from 2 to 1 and 0, so keeping address/size-cells was
kind of intentional. Anyway, these should not be needed, so:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: sm8650: Fix compile warnings in USB controller node

[Krzysztof Kozlowski]

On 03/12/2025 15:48, Krishna Kurapati wrote:
> With W=1, the following error comes up:
> 
> Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
> 
> This is because the child node being removed during flattening and moving
> to latest bindings.
> 
> Fixes: 77e1f16b9302 ("arm64: dts: qcom: sm8650: Flatten the USB nodes")
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH 0/2] Fix compile warnings for SM8550 and SM8650

[Dmitry Baryshkov]

On Wed, Dec 03, 2025 at 08:18:54PM +0530, Krishna Kurapati wrote:
> arch/arm64/boot/dts/qcom/sm8550.dtsi:4133.22-4223.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
> 
> arch/arm64/boot/dts/qcom/sm8650.dtsi:5086.22-5177.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
> 
> Fix them up accordingly.
> 
> This series has only been compile tested.
> 
> Krishna Kurapati (2):
>   arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node
>   arm64: dts: qcom: sm8650: Fix compile warnings in USB controller node
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

Re: [PATCH 0/2] Fix compile warnings for SM8550 and SM8650

[Bjorn Andersson]

On Wed, 03 Dec 2025 20:18:54 +0530, Krishna Kurapati wrote:
> arch/arm64/boot/dts/qcom/sm8550.dtsi:4133.22-4223.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
> 
> arch/arm64/boot/dts/qcom/sm8650.dtsi:5086.22-5177.5: Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
> 
> Fix them up accordingly.
> 
> This series has only been compile tested.
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node
      commit: 2d0165726d20395cb700546b1528df3fa614e5a3
[2/2] arm64: dts: qcom: sm8650: Fix compile warnings in USB controller node
      commit: 825db404fbed0580deb19f587d69b9f75980055a

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH 1/2] arm64: dts: qcom: sm8550: Fix compile warnings in USB controller node

[Neil Armstrong]

On 12/3/25 16:07, Krzysztof Kozlowski wrote:
> On 03/12/2025 15:48, Krishna Kurapati wrote:
>> With W=1, the following error comes up:
>>
>> Warning (avoid_unnecessary_addr_size): /soc@0/usb@a600000: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" or "ranges" property
>>
>> This is because the child node being removed during flattening and moving
>> to latest bindings.
>>
>> Fixes: 33450878adfc ("arm64: dts: qcom: sm8550: Flatten the USB nodes")
> 
> 
> I don't fully understand that original commit - it explicitly changed
> address/size-cells from 2 to 1 and 0, so keeping address/size-cells was
> kind of intentional. Anyway, these should not be needed, so:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

They were kept to allow adding usb submodes representing usb devices,
as the bindings allows. It's not _needed_ until we add some subnodes.

Neil

> 
> Best regards,
> Krzysztof