[PATCH V2 0/2] Add initial support for RDP468 of IPQ5332 family

[PATCH V2 0/2] Add initial support for RDP468 of IPQ5332 family

[Kathiravan T]

Add the initial device tree support for the RDP(Reference Design
Platform)468 based on IPQ5332 family of SoCs. This patch carries the
support for Console UART, SPI NOR, eMMC.

This series depends on the below which adds support the SPI NOR
https://lore.kernel.org/linux-arm-msm/20230320104530.30411-1-quic_kathirav@quicinc.com/

V1 can be found here
https://lore.kernel.org/linux-arm-msm/20230323044929.8694-1-quic_kathirav@quicinc.com/

Kathiravan T (2):
  dt-bindings: arm: qcom: document MI01.6 board based on IPQ5332 family
  arm64: dts: qcom: ipq5332: add support for the RDP468 variant

 .../devicetree/bindings/arm/qcom.yaml         |   2 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts   | 103 ++++++++++++++++++
 3 files changed, 106 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts

-- 
2.17.1

[PATCH V2 1/2] dt-bindings: arm: qcom: document MI01.6 board based on IPQ5332 family

[Kathiravan T]

Document the MI01.6 (Reference Design Platform 468) board based on IPQ5332
family of SoCs.

Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- Updated the subject prefix

 Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 05badce5fedc..a2dacce49197 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -84,6 +84,7 @@ description: |
         adp
         ap-al02-c7
         ap-mi01.2
+        ap-mi01.6
         cdp
         cp01-c1
         dragonboard
@@ -327,6 +328,7 @@ properties:
       - items:
           - enum:
               - qcom,ipq5332-ap-mi01.2
+              - qcom,ipq5332-ap-mi01.6
           - const: qcom,ipq5332
 
       - items:
-- 
2.17.1

Re: [PATCH V2 1/2] dt-bindings: arm: qcom: document MI01.6 board based on IPQ5332 family

[Krzysztof Kozlowski]

On 23/03/2023 10:31, Kathiravan T wrote:
> Document the MI01.6 (Reference Design Platform 468) board based on IPQ5332
> family of SoCs.
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH V2 2/2] arm64: dts: qcom: ipq5332: add support for the RDP468 variant

[Kathiravan T]

Add the initial device tree support for the Reference Design
Platform(RDP) 468 based on IPQ5332 family of SoCs. This patch carries the
support for Console UART, SPI NOR, eMMC.

Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- Moved the 'reg' property after 'compatible'

 arch/arm64/boot/dts/qcom/Makefile           |   1 +
 arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 103 ++++++++++++++++++++
 2 files changed, 104 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 1a29403400b7..79cf8373997f 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-mi01.2.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp468.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq6018-cp01-c1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk01.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq8074-hk10-c1.dtb
diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
new file mode 100644
index 000000000000..3b6a5cb8bf07
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
@@ -0,0 +1,103 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * IPQ5332 RDP468 board device tree source
+ *
+ * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "ipq5332.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ5332 MI01.6";
+	compatible = "qcom,ipq5332-ap-mi01.6", "qcom,ipq5332";
+
+	aliases {
+		serial0 = &blsp1_uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0";
+	};
+};
+
+&blsp1_uart0 {
+	pinctrl-0 = <&serial_0_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&blsp1_spi0 {
+	pinctrl-0 = <&spi_0_data_clk_pins &spi_0_cs_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	flash@0 {
+		compatible = "micron,n25q128a11", "jedec,spi-nor";
+		reg = <0>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		spi-max-frequency = <50000000>;
+	};
+};
+
+&sdhc {
+	bus-width = <4>;
+	max-frequency = <192000000>;
+	mmc-ddr-1_8v;
+	mmc-hs200-1_8v;
+	non-removable;
+	pinctrl-0 = <&sdc_default_state>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&sleep_clk {
+	clock-frequency = <32000>;
+};
+
+&xo_board {
+	clock-frequency = <24000000>;
+};
+
+/* PINCTRL */
+
+&tlmm {
+	sdc_default_state: sdc-default-state {
+		clk-pins {
+			pins = "gpio13";
+			function = "sdc_clk";
+			drive-strength = <8>;
+			bias-disable;
+		};
+
+		cmd-pins {
+			pins = "gpio12";
+			function = "sdc_cmd";
+			drive-strength = <8>;
+			bias-pull-up;
+		};
+
+		data-pins {
+			pins = "gpio8", "gpio9", "gpio10", "gpio11";
+			function = "sdc_data";
+			drive-strength = <8>;
+			bias-pull-up;
+		};
+	};
+
+	spi_0_data_clk_pins: spi-0-data-clk-state {
+		pins = "gpio14", "gpio15", "gpio16";
+		function = "blsp0_spi";
+		drive-strength = <2>;
+		bias-pull-down;
+	};
+
+	spi_0_cs_pins: spi-0-cs-state {
+		pins = "gpio17";
+		function = "blsp0_spi";
+		drive-strength = <2>;
+		bias-pull-up;
+	};
+};
-- 
2.17.1

Re: [PATCH V2 2/2] arm64: dts: qcom: ipq5332: add support for the RDP468 variant

[Krzysztof Kozlowski]

On 23/03/2023 10:31, Kathiravan T wrote:
> Add the initial device tree support for the Reference Design
> Platform(RDP) 468 based on IPQ5332 family of SoCs. This patch carries the
> support for Console UART, SPI NOR, eMMC.
> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
> 	- Moved the 'reg' property after 'compatible'
> 
>  arch/arm64/boot/dts/qcom/Makefile           |   1 +
>  arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 103 ++++++++++++++++++++
>  2 files changed, 104 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts

Hi,

Your v1 was reported that it does not build. Does this patch build fine?

Best regards,
Krzysztof

Re: [PATCH V2 2/2] arm64: dts: qcom: ipq5332: add support for the RDP468 variant

[Kathiravan T]

On 3/23/2023 4:26 PM, Krzysztof Kozlowski wrote:
> On 23/03/2023 10:31, Kathiravan T wrote:
>> Add the initial device tree support for the Reference Design
>> Platform(RDP) 468 based on IPQ5332 family of SoCs. This patch carries the
>> support for Console UART, SPI NOR, eMMC.
>>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>> Changes in V2:
>> 	- Moved the 'reg' property after 'compatible'
>>
>>   arch/arm64/boot/dts/qcom/Makefile           |   1 +
>>   arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 103 ++++++++++++++++++++
>>   2 files changed, 104 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> Hi,
>
> Your v1 was reported that it does not build. Does this patch build fine?
As mentioned in the cover letter,

This series depends on the below which adds support the SPI NOR

https://lore.kernel.org/linux-arm-msm/20230320104530.30411-1-quic_kathirav@quicinc.com/

Thanks,

Kathiravan T.

Re: [PATCH V2 2/2] arm64: dts: qcom: ipq5332: add support for the RDP468 variant

[Kathiravan T]

On 3/23/2023 4:47 PM, Kathiravan T wrote:
>
> On 3/23/2023 4:26 PM, Krzysztof Kozlowski wrote:
>> On 23/03/2023 10:31, Kathiravan T wrote:
>>> Add the initial device tree support for the Reference Design
>>> Platform(RDP) 468 based on IPQ5332 family of SoCs. This patch 
>>> carries the
>>> support for Console UART, SPI NOR, eMMC.
>>>
>>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>>> ---
>>> Changes in V2:
>>>     - Moved the 'reg' property after 'compatible'
>>>
>>>   arch/arm64/boot/dts/qcom/Makefile           |   1 +
>>>   arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 103 
>>> ++++++++++++++++++++
>>>   2 files changed, 104 insertions(+)
>>>   create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
>> Hi,
>>
>> Your v1 was reported that it does not build. Does this patch build fine?
> As mentioned in the cover letter,
>
> This series depends on the below which adds support the SPI NOR
>
> https://lore.kernel.org/linux-arm-msm/20230320104530.30411-1-quic_kathirav@quicinc.com/ 
>


Given that, this series and the dependent series has only DTS changes, 
and also both series has V2, is it okay If I squash them into single 
series and send it?


Thanks, Kathiravan T.

Re: [PATCH V2 0/2] Add initial support for RDP468 of IPQ5332 family

[Kathiravan T]

On 3/23/2023 3:01 PM, Kathiravan T wrote:
> Add the initial device tree support for the RDP(Reference Design
> Platform)468 based on IPQ5332 family of SoCs. This patch carries the
> support for Console UART, SPI NOR, eMMC.
>
> This series depends on the below which adds support the SPI NOR
> https://lore.kernel.org/linux-arm-msm/20230320104530.30411-1-quic_kathirav@quicinc.com/
>
> V1 can be found here
> https://lore.kernel.org/linux-arm-msm/20230323044929.8694-1-quic_kathirav@quicinc.com/


Gentle Reminder...


>
> Kathiravan T (2):
>    dt-bindings: arm: qcom: document MI01.6 board based on IPQ5332 family
>    arm64: dts: qcom: ipq5332: add support for the RDP468 variant
>
>   .../devicetree/bindings/arm/qcom.yaml         |   2 +
>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>   arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts   | 103 ++++++++++++++++++
>   3 files changed, 106 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
>

Re: (subset) [PATCH V2 0/2] Add initial support for RDP468 of IPQ5332 family

[Bjorn Andersson]

On Thu, 23 Mar 2023 15:01:18 +0530, Kathiravan T wrote:
> Add the initial device tree support for the RDP(Reference Design
> Platform)468 based on IPQ5332 family of SoCs. This patch carries the
> support for Console UART, SPI NOR, eMMC.
> 
> This series depends on the below which adds support the SPI NOR
> https://lore.kernel.org/linux-arm-msm/20230320104530.30411-1-quic_kathirav@quicinc.com/
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: qcom: ipq5332: add support for the RDP468 variant
      commit: f1d33c902a1be727416fce3161db37a84d3f38d1

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>