* [PATCH v2 1/2] arm64: dts: qcom: sdx75: Flatten usb controller node
2025-11-14 6:15 [PATCH v2 0/2] Flatten usb controller node on SDX75 Krishna Kurapati
@ 2025-11-14 6:15 ` Krishna Kurapati
2025-11-14 11:13 ` Dmitry Baryshkov
2025-11-14 21:36 ` Konrad Dybcio
2025-11-14 6:15 ` [PATCH v2 2/2] arm64: dts: qcom: sdx75: Add missing usb-role-switch property Krishna Kurapati
2025-11-14 21:26 ` [PATCH v2 0/2] Flatten usb controller node on SDX75 Bjorn Andersson
2 siblings, 2 replies; 7+ messages in thread
From: Krishna Kurapati @ 2025-11-14 6:15 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov, Konrad Dybcio
Cc: linux-arm-msm, devicetree, linux-kernel, Krishna Kurapati
Flatten usb controller node and update to using latest bindings
and flattened driver approach.
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sdx75-idp.dts | 6 +--
arch/arm64/boot/dts/qcom/sdx75.dtsi | 66 ++++++++++++--------------
2 files changed, 33 insertions(+), 39 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
index 06cacec3461f..6696e1aee243 100644
--- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
@@ -337,11 +337,9 @@ &uart1 {
};
&usb {
- status = "okay";
-};
-
-&usb_dwc3 {
dr_mode = "peripheral";
+
+ status = "okay";
};
&usb_hsphy {
diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
index f26ba90ba66d..e586b55c155b 100644
--- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
@@ -1019,12 +1019,9 @@ opp-384000000 {
};
};
- usb: usb@a6f8800 {
- compatible = "qcom,sdx75-dwc3", "qcom,dwc3";
- reg = <0x0 0x0a6f8800 0x0 0x400>;
- #address-cells = <2>;
- #size-cells = <2>;
- ranges;
+ usb: usb@a600000 {
+ compatible = "qcom,sdx75-dwc3", "qcom,snps-dwc3";
+ reg = <0x0 0x0a600000 0x0 0xfc100>;
clocks = <&gcc GCC_USB30_SLV_AHB_CLK>,
<&gcc GCC_USB30_MASTER_CLK>,
@@ -1041,21 +1038,35 @@ usb: usb@a6f8800 {
<&gcc GCC_USB30_MASTER_CLK>;
assigned-clock-rates = <19200000>, <200000000>;
- interrupts-extended = <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>,
+ interrupts-extended = <&intc GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>,
+ <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>,
<&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>,
<&pdc 10 IRQ_TYPE_EDGE_RISING>,
<&pdc 9 IRQ_TYPE_EDGE_RISING>,
<&pdc 17 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "pwr_event",
+ interrupt-names = "dwc_usb3",
+ "pwr_event",
"hs_phy_irq",
"dp_hs_phy_irq",
"dm_hs_phy_irq",
"ss_phy_irq";
+ iommus = <&apps_smmu 0x80 0x0>;
+
+ snps,dis_u2_susphy_quirk;
+ snps,dis_enblslpm_quirk;
+ snps,dis-u1-entry-quirk;
+ snps,dis-u2-entry-quirk;
+
power-domains = <&gcc GCC_USB30_GDSC>;
resets = <&gcc GCC_USB30_BCR>;
+ phys = <&usb_hsphy>,
+ <&usb_qmpphy>;
+ phy-names = "usb2-phy",
+ "usb3-phy";
+
interconnects = <&system_noc MASTER_USB3_0 QCOM_ICC_TAG_ALWAYS
&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
@@ -1065,36 +1076,21 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
status = "disabled";
- usb_dwc3: usb@a600000 {
- compatible = "snps,dwc3";
- reg = <0x0 0x0a600000 0x0 0xcd00>;
- interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
- iommus = <&apps_smmu 0x80 0x0>;
- snps,dis_u2_susphy_quirk;
- snps,dis_enblslpm_quirk;
- snps,dis-u1-entry-quirk;
- snps,dis-u2-entry-quirk;
- phys = <&usb_hsphy>,
- <&usb_qmpphy>;
- phy-names = "usb2-phy",
- "usb3-phy";
-
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@0 {
- reg = <0>;
-
- usb_1_dwc3_hs: endpoint {
- };
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ usb_1_dwc3_hs: endpoint {
};
+ };
- port@1 {
- reg = <1>;
+ port@1 {
+ reg = <1>;
- usb_1_dwc3_ss: endpoint {
- };
+ usb_1_dwc3_ss: endpoint {
};
};
};
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 2/2] arm64: dts: qcom: sdx75: Add missing usb-role-switch property
2025-11-14 6:15 [PATCH v2 0/2] Flatten usb controller node on SDX75 Krishna Kurapati
2025-11-14 6:15 ` [PATCH v2 1/2] arm64: dts: qcom: sdx75: Flatten usb controller node Krishna Kurapati
@ 2025-11-14 6:15 ` Krishna Kurapati
2025-11-14 11:14 ` Dmitry Baryshkov
2025-11-14 21:26 ` [PATCH v2 0/2] Flatten usb controller node on SDX75 Bjorn Andersson
2 siblings, 1 reply; 7+ messages in thread
From: Krishna Kurapati @ 2025-11-14 6:15 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov, Konrad Dybcio
Cc: linux-arm-msm, devicetree, linux-kernel, Krishna Kurapati
Add missing usb-role-switch property to usb controller node.
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/sdx75.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
index e586b55c155b..6e7695146ff8 100644
--- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
@@ -1074,6 +1074,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
interconnect-names = "usb-ddr",
"apps-usb";
+ usb-role-switch;
status = "disabled";
ports {
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2 0/2] Flatten usb controller node on SDX75
2025-11-14 6:15 [PATCH v2 0/2] Flatten usb controller node on SDX75 Krishna Kurapati
2025-11-14 6:15 ` [PATCH v2 1/2] arm64: dts: qcom: sdx75: Flatten usb controller node Krishna Kurapati
2025-11-14 6:15 ` [PATCH v2 2/2] arm64: dts: qcom: sdx75: Add missing usb-role-switch property Krishna Kurapati
@ 2025-11-14 21:26 ` Bjorn Andersson
2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2025-11-14 21:26 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Dmitry Baryshkov, Konrad Dybcio, Krishna Kurapati
Cc: linux-arm-msm, devicetree, linux-kernel
On Fri, 14 Nov 2025 11:45:51 +0530, Krishna Kurapati wrote:
> Flatten usb controller node and update to using latest bindings and
> flattened driver approach. While at it, add the usb-role-switch property
> to usb controller node.
>
Applied, thanks!
[1/2] arm64: dts: qcom: sdx75: Flatten usb controller node
commit: 101dae743d4bfa1c779de4ef1c65393cc4824d4e
[2/2] arm64: dts: qcom: sdx75: Add missing usb-role-switch property
commit: f481e772e014da92fa1232de54e4cac66b5fc5e4
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread