[PATCH] arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

[PATCH] arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

[Rob Herring (Arm)]

Remove "constant_charge_voltage_max_microvolt" property which is both
unused in the kernel and undocumented. Most likely they are leftovers
from downstream.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
index 095b24a31313..e60838695d0e 100644
--- a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
+++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
@@ -71,7 +71,6 @@ bat: battery {
 		compatible = "simple-battery";
 		charge-full-design-microamp-hours = <1900000>;
 		charge-term-current-microamp = <120000>;
-		constant_charge_voltage_max_microvolt = <4350000>;
 		internal-resistance-micro-ohms = <250000>;
 		ocv-capacity-celsius = <20>;
 		ocv-capacity-table-0 = <4185000 100>, <4113000 95>, <4066000 90>,
-- 
2.45.2

Re: [PATCH] arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

[Baolin Wang]

On 2024/11/16 03:34, Rob Herring (Arm) wrote:
> Remove "constant_charge_voltage_max_microvolt" property which is both
> unused in the kernel and undocumented. Most likely they are leftovers
> from downstream.

Yes. LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>   arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> index 095b24a31313..e60838695d0e 100644
> --- a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> @@ -71,7 +71,6 @@ bat: battery {
>   		compatible = "simple-battery";
>   		charge-full-design-microamp-hours = <1900000>;
>   		charge-term-current-microamp = <120000>;
> -		constant_charge_voltage_max_microvolt = <4350000>;
>   		internal-resistance-micro-ohms = <250000>;
>   		ocv-capacity-celsius = <20>;
>   		ocv-capacity-table-0 = <4185000 100>, <4113000 95>, <4066000 90>,

Re: [PATCH] arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

[Stanislav Jakubek]

Hi Rob,

constant-charge-voltage-max-microvolt is a valid property, which I assume
was the original intention here. I've already submitted a patch changing this
to the documented property:

https://lore.kernel.org/lkml/aa557091d9494fdaa3eda75803f9ea97014c8832.1730918663.git.stano.jakubek@gmail.com/

Baolin also reviewed that patch... make of that what you will.

Regards,
Stanislav

Re: [PATCH] arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

[Baolin Wang]

On 2024/11/20 20:14, Stanislav Jakubek wrote:
> Hi Rob,
> 
> constant-charge-voltage-max-microvolt is a valid property, which I assume
> was the original intention here. I've already submitted a patch changing this
> to the documented property:
> 
> https://lore.kernel.org/lkml/aa557091d9494fdaa3eda75803f9ea97014c8832.1730918663.git.stano.jakubek@gmail.com/
> 
> Baolin also reviewed that patch... make of that what you will.

Ah, yes. Sorry I forgot your patch. Thanks for reminding.

Re: [PATCH] arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

[Krzysztof Kozlowski]

On 20/11/2024 13:27, Baolin Wang wrote:
> 
> 
> On 2024/11/20 20:14, Stanislav Jakubek wrote:
>> Hi Rob,
>>
>> constant-charge-voltage-max-microvolt is a valid property, which I assume
>> was the original intention here. I've already submitted a patch changing this
>> to the documented property:
>>
>> https://lore.kernel.org/lkml/aa557091d9494fdaa3eda75803f9ea97014c8832.1730918663.git.stano.jakubek@gmail.com/
>>
>> Baolin also reviewed that patch... make of that what you will.
> 
> Ah, yes. Sorry I forgot your patch. Thanks for reminding.

No one picked them up... I kept Stanislav's patches in my incoming/inbox
folder for quite long time, because I pick up some random fixes here and
there, but then forgot them and did not apply for v6.13-rc1. So they
missed v6.13-rc1.

I am not the maintainer of that platform, so I don't care about it
really, but I care about contributors work not being lost/ignored.

What is the plan with these and all other Spreadtrum patches? Are they
going to be applied by you or other Spreadtrum maintainers? Do you need
any help from us? Or maybe some clarifications of the process?

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

[Chunyan Zhang]

Hi Krzysztof,

On Wed, 20 Nov 2024 at 22:25, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 20/11/2024 13:27, Baolin Wang wrote:
> >
> >
> > On 2024/11/20 20:14, Stanislav Jakubek wrote:
> >> Hi Rob,
> >>
> >> constant-charge-voltage-max-microvolt is a valid property, which I assume
> >> was the original intention here. I've already submitted a patch changing this
> >> to the documented property:
> >>
> >> https://lore.kernel.org/lkml/aa557091d9494fdaa3eda75803f9ea97014c8832.1730918663.git.stano.jakubek@gmail.com/
> >>
> >> Baolin also reviewed that patch... make of that what you will.
> >
> > Ah, yes. Sorry I forgot your patch. Thanks for reminding.
>
> No one picked them up... I kept Stanislav's patches in my incoming/inbox
> folder for quite long time, because I pick up some random fixes here and
> there, but then forgot them and did not apply for v6.13-rc1. So they
> missed v6.13-rc1.
>
> I am not the maintainer of that platform, so I don't care about it
> really, but I care about contributors work not being lost/ignored.
>
> What is the plan with these and all other Spreadtrum patches? Are they
> going to be applied by you or other Spreadtrum maintainers? Do you need
> any help from us? Or maybe some clarifications of the process?

Yes we need your help!

The Spreadtrum DTS patches had been being maintained through my tree.
I'm not suitable to do this any more due to some changes (I've moved
myself to the reviewer entry of sprd).

After discussion with other sprd maintainers, we still want the
Spreadtrum patches to go through your tree if you agree.

Thanks for all the help,
Chunyan

>
> Best regards,
> Krzysztof

Re: [PATCH] arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

[Krzysztof Kozlowski]

On 21/11/2024 04:04, Chunyan Zhang wrote:
> Hi Krzysztof,
> 
> On Wed, 20 Nov 2024 at 22:25, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 20/11/2024 13:27, Baolin Wang wrote:
>>>
>>>
>>> On 2024/11/20 20:14, Stanislav Jakubek wrote:
>>>> Hi Rob,
>>>>
>>>> constant-charge-voltage-max-microvolt is a valid property, which I assume
>>>> was the original intention here. I've already submitted a patch changing this
>>>> to the documented property:
>>>>
>>>> https://lore.kernel.org/lkml/aa557091d9494fdaa3eda75803f9ea97014c8832.1730918663.git.stano.jakubek@gmail.com/
>>>>
>>>> Baolin also reviewed that patch... make of that what you will.
>>>
>>> Ah, yes. Sorry I forgot your patch. Thanks for reminding.
>>
>> No one picked them up... I kept Stanislav's patches in my incoming/inbox
>> folder for quite long time, because I pick up some random fixes here and
>> there, but then forgot them and did not apply for v6.13-rc1. So they
>> missed v6.13-rc1.
>>
>> I am not the maintainer of that platform, so I don't care about it
>> really, but I care about contributors work not being lost/ignored.
>>
>> What is the plan with these and all other Spreadtrum patches? Are they
>> going to be applied by you or other Spreadtrum maintainers? Do you need
>> any help from us? Or maybe some clarifications of the process?
> 
> Yes we need your help!
> 
> The Spreadtrum DTS patches had been being maintained through my tree.
> I'm not suitable to do this any more due to some changes (I've moved
> myself to the reviewer entry of sprd).
> 
> After discussion with other sprd maintainers, we still want the
> Spreadtrum patches to go through your tree if you agree.

+Cc Arnd,

With few folks we talked briefly on IRC, but that probably missed some
audience. I was indeed taking orphaned fixes, not only for Spreadtrum
but also other trees, but that's different than maintaining. I don't
feel comfortable taking any features or making any maintenance decisions
about Spreadtrum, so I should not be listed in MAINTAINERS file. If I am
not listed there, it is likely I will miss patches, so me picking up
fixes here solves current issue, but does not really solve the problem
long term.

If there is no one willing to handle patches for Spreadtrum, maybe the
platform's status should be changed from Maintained to "Odd Fixes"?

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

[Rob Herring]

On Wed, Nov 20, 2024 at 6:14 AM Stanislav Jakubek
<stano.jakubek@gmail.com> wrote:
>
> Hi Rob,
>
> constant-charge-voltage-max-microvolt is a valid property, which I assume
> was the original intention here. I've already submitted a patch changing this
> to the documented property:
>
> https://lore.kernel.org/lkml/aa557091d9494fdaa3eda75803f9ea97014c8832.1730918663.git.stano.jakubek@gmail.com/

Ok, thanks. We should apply your patch instead.

Rob