mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, Armin Wolf <W_Armin@gmx.de>
Subject: Re: Page select register restrictions in regmap core
Date: Tue, 18 Jun 2024 12:33:40 -0700	[thread overview]
Message-ID: <3b47b5e3-4eb2-43f9-8f4f-c021d203305e@roeck-us.net> (raw)
In-Reply-To: <44d4fce5-2ec9-4f62-b7ac-a317c7d843db@sirena.org.uk>

On 6/18/24 10:45, Mark Brown wrote:
> On Tue, Jun 18, 2024 at 09:14:56AM -0700, Guenter Roeck wrote:
> 
>> Anyway, this may be all irrelevant in respect to regmap support.
>> It turns out that at least some i801 controllers don't work with the
>> access mechanism used by regmap, or maybe the spd5118 chips don't support
>> I2C_FUNC_SMBUS_I2C_BLOCK. I already found that those chips don't support
>> auto-incrementing the register address and actually reset the address on byte
>> reads (i.e., subsequent calls to i2c_smbus_read_byte() always return the data
>> from the first register). Since regmap doesn't have a means for me to say
>> "don't use I2C_FUNC_SMBUS_I2C_BLOCK even if the controller supports it",
>> I may have to drop regmap support entirely anyway. That would be annoying,
>> but right now I have no idea how to work around that problem.
> 
> You can set the use_single_read and use_single_write flags in the config
> to ensure registers are accessed one at a time, that restriction is
> moderately common.

That doesn't help, unfortunately. Thinking about it, that is not really
surprising. The failing write is to the page register, and that was
a single write anyway.

Thanks,
Guenter


  parent reply	other threads:[~2024-06-18 19:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 14:20 Guenter Roeck
2024-06-17 15:08 ` Mark Brown
2024-06-17 16:59   ` Guenter Roeck
2024-06-17 17:22     ` Mark Brown
2024-06-17 21:55       ` Guenter Roeck
2024-06-17 22:47         ` Mark Brown
2024-06-17 23:15           ` Guenter Roeck
2024-06-18 11:35             ` Mark Brown
2024-06-18 16:14               ` Guenter Roeck
2024-06-18 17:01                 ` Guenter Roeck
2024-06-18 17:45                 ` Mark Brown
2024-06-18 18:10                   ` Guenter Roeck
2024-06-18 19:33                   ` Guenter Roeck [this message]
2024-06-18 20:46                     ` Mark Brown
2024-06-18 21:23                       ` Guenter Roeck
2024-06-19  3:11                       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b47b5e3-4eb2-43f9-8f4f-c021d203305e@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=W_Armin@gmx.de \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®