From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Zide Chen <zide.chen@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf test: Avoid call to missing cleanup function
Date: Mon, 7 Sep 2026 14:47:17 +0800 [thread overview]
Message-ID: <3b4cee11-a3e7-4c31-bc5d-a992f00db0c3@linux.intel.com> (raw)
In-Reply-To: <20260904194954.1192154-1-irogers@google.com>
LGTM. Thanks.
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
On 9/5/2026 3:49 AM, Ian Rogers wrote:
> Cleanup function was removed by writing to /dev/null rather than
> temporary files. The exit path still had a call.
>
> Fixes: 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/test_event_open_fallback.sh b/tools/perf/tests/shell/test_event_open_fallback.sh
> index 9420a7557c13..27d440a5355d 100755
> --- a/tools/perf/tests/shell/test_event_open_fallback.sh
> +++ b/tools/perf/tests/shell/test_event_open_fallback.sh
> @@ -57,8 +57,6 @@ ret=0
> test_decrease_precise_ip || ret=$? ; count_result $ret ; ret=0
> test_decrease_precise_ip_complicated || ret=$? ; count_result $ret ; ret=0
>
> -cleanup
> -
> if [ ${err_cnt} -gt 0 ] ; then
> exit 1
> fi
next prev parent reply other threads:[~2026-09-07 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 19:49 Ian Rogers
2026-09-07 6:47 ` Mi, Dapeng [this message]
2026-09-08 21:14 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b4cee11-a3e7-4c31-bc5d-a992f00db0c3@linux.intel.com \
--to=dapeng1.mi@linux.intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=zide.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®