* [PATCH v1] perf test: Avoid call to missing cleanup function
@ 2026-09-04 19:49 Ian Rogers
2026-09-07 6:47 ` Mi, Dapeng
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2026-09-04 19:49 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Jiri Olsa, Ian Rogers, Adrian Hunter, James Clark,
Dapeng Mi, Zide Chen, linux-perf-users, linux-kernel
Cleanup function was removed by writing to /dev/null rather than
temporary files. The exit path still had a call.
Fixes: 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/perf/tests/shell/test_event_open_fallback.sh b/tools/perf/tests/shell/test_event_open_fallback.sh
index 9420a7557c13..27d440a5355d 100755
--- a/tools/perf/tests/shell/test_event_open_fallback.sh
+++ b/tools/perf/tests/shell/test_event_open_fallback.sh
@@ -57,8 +57,6 @@ ret=0
test_decrease_precise_ip || ret=$? ; count_result $ret ; ret=0
test_decrease_precise_ip_complicated || ret=$? ; count_result $ret ; ret=0
-cleanup
-
if [ ${err_cnt} -gt 0 ] ; then
exit 1
fi
--
2.55.0.979.g7e5102b832-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf test: Avoid call to missing cleanup function
2026-09-04 19:49 [PATCH v1] perf test: Avoid call to missing cleanup function Ian Rogers
@ 2026-09-07 6:47 ` Mi, Dapeng
2026-09-08 21:14 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Mi, Dapeng @ 2026-09-07 6:47 UTC (permalink / raw)
To: Ian Rogers, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim, Jiri Olsa, Adrian Hunter,
James Clark, Zide Chen, linux-perf-users, linux-kernel
LGTM. Thanks.
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
On 9/5/2026 3:49 AM, Ian Rogers wrote:
> Cleanup function was removed by writing to /dev/null rather than
> temporary files. The exit path still had a call.
>
> Fixes: 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/test_event_open_fallback.sh b/tools/perf/tests/shell/test_event_open_fallback.sh
> index 9420a7557c13..27d440a5355d 100755
> --- a/tools/perf/tests/shell/test_event_open_fallback.sh
> +++ b/tools/perf/tests/shell/test_event_open_fallback.sh
> @@ -57,8 +57,6 @@ ret=0
> test_decrease_precise_ip || ret=$? ; count_result $ret ; ret=0
> test_decrease_precise_ip_complicated || ret=$? ; count_result $ret ; ret=0
>
> -cleanup
> -
> if [ ${err_cnt} -gt 0 ] ; then
> exit 1
> fi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] perf test: Avoid call to missing cleanup function
2026-09-07 6:47 ` Mi, Dapeng
@ 2026-09-08 21:14 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-09-08 21:14 UTC (permalink / raw)
To: Mi, Dapeng
Cc: Ian Rogers, Peter Zijlstra, Ingo Molnar, Namhyung Kim, Jiri Olsa,
Adrian Hunter, James Clark, Zide Chen, linux-perf-users,
linux-kernel
On Mon, Sep 07, 2026 at 02:47:17PM +0800, Mi, Dapeng wrote:
> LGTM. Thanks.
>
> Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
> On 9/5/2026 3:49 AM, Ian Rogers wrote:
> > Cleanup function was removed by writing to /dev/null rather than
> > temporary files. The exit path still had a call.
> >
> > Fixes: 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/tools/perf/tests/shell/test_event_open_fallback.sh b/tools/perf/tests/shell/test_event_open_fallback.sh
> > index 9420a7557c13..27d440a5355d 100755
> > --- a/tools/perf/tests/shell/test_event_open_fallback.sh
> > +++ b/tools/perf/tests/shell/test_event_open_fallback.sh
> > @@ -57,8 +57,6 @@ ret=0
> > test_decrease_precise_ip || ret=$? ; count_result $ret ; ret=0
> > test_decrease_precise_ip_complicated || ret=$? ; count_result $ret ; ret=0
> >
> > -cleanup
> > -
> > if [ ${err_cnt} -gt 0 ] ; then
> > exit 1
> > fi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-08 21:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-04 19:49 [PATCH v1] perf test: Avoid call to missing cleanup function Ian Rogers
2026-09-07 6:47 ` Mi, Dapeng
2026-09-08 21:14 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®