mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>
To: Stephen Boyd <swboyd@chromium.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Das Srinagesh <gurus@codeaurora.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <quic_collinsd@quicinc.com>,
	<quic_subbaram@quicinc.com>, <quic_jprakash@quicinc.com>
Subject: Re: [PATCH V8 7/7] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp
Date: Fri, 1 Apr 2022 16:18:46 +0530	[thread overview]
Message-ID: <3b4dcf83-bb13-2159-d7c1-f0aadfc53566@quicinc.com> (raw)
In-Reply-To: <CAE-0n52CVuc_kQbpwEnHEEODS8jPt52v6P=gAdVxqenPu4ehkw@mail.gmail.com>


On 4/1/2022 2:48 AM, Stephen Boyd wrote:
> Quoting Satya Priya Kakitapalli (Temp) (2022-03-30 03:44:01)
>> On 3/25/2022 11:18 PM, Stephen Boyd wrote:
>>>        #include "pm8008.dtsi"
>>>
>>> and then the nodes below.
>>
>> You mean
>>
>> pm8008_bus: &i2c1 {
>>
>>           status = "okay";
>>
>> };
>>
>> &pm8008_bus {
>>
>>       #include "pm8008.dtsi"
>>
>> };
>>
>> and remaining nodes, right?
>>
> No. I meant what I wrote.
>

Okay thank you for elaborating,


>         &pm8008_bus: &i2c1 {


but this still needs to be "pm8008_bus: &i2c {" right.. no '&' before 
pm8008_bus.


>                 status = "okay";
>         };
>
>         #include "pm8008.dtsi"
>
> and then the pm8008.dtsi file would have
>
> 	&pm8008_bus {
> 		pm8008: pmic@8 {
> 			compatible = "qcom,pm8008";
> 			...
> 		};
>
> 		pm8008_regulators: regulators@9 {
> 			compatible = "qcom,pm8008-regulators";
> 			...
> 		};
> 	};
>
> and then this patch would modify those nodes with phandles.

  reply	other threads:[~2022-04-01 10:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25 11:58 [PATCH V8 0/7] Add Qualcomm Technologies, Inc. PM8008 regulator driver Satya Priya
2022-03-25 11:58 ` [PATCH V8 1/7] dt-bindings: mfd: pm8008: Modify the compatible as per driver Satya Priya
2022-03-25 18:02   ` Stephen Boyd
2022-03-30 10:55     ` Satya Priya Kakitapalli (Temp)
2022-03-31 21:15       ` Stephen Boyd
2022-04-04 12:53         ` Satya Priya Kakitapalli (Temp)
2022-03-25 11:58 ` [PATCH V8 2/7] dt-bindings: mfd: pm8008: Add pm8008 regulator bindings Satya Priya
2022-03-25 18:08   ` Stephen Boyd
2022-03-30 10:56     ` Satya Priya Kakitapalli (Temp)
2022-03-25 11:58 ` [PATCH V8 3/7] mfd: pm8008: Add mfd cell struct to register LDOs Satya Priya
2022-03-25 11:58 ` [PATCH V8 4/7] regulator: Add a regulator driver for the PM8008 PMIC Satya Priya
2022-03-25 11:58 ` [PATCH V8 5/7] arm64: dts: qcom: pm8008-infra: Add base dts file for pm8008 infra Satya Priya
2022-03-25 11:58 ` [PATCH V8 6/7] arm64: dts: qcom: pm8008-regulators: Add base dts file for pm8008 regulators Satya Priya
2022-03-25 17:43   ` Stephen Boyd
2022-03-30 10:36     ` Satya Priya Kakitapalli (Temp)
2022-03-25 11:58 ` [PATCH V8 7/7] arm64: dts: qcom: sc7280: Add pm8008 support for sc7280-idp Satya Priya
2022-03-25 17:48   ` Stephen Boyd
2022-03-30 10:44     ` Satya Priya Kakitapalli (Temp)
2022-03-31 21:18       ` Stephen Boyd
2022-04-01 10:48         ` Satya Priya Kakitapalli (Temp) [this message]
2022-04-01 18:48           ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b4dcf83-bb13-2159-d7c1-f0aadfc53566@quicinc.com \
    --to=quic_c_skakit@quicinc.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gurus@codeaurora.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_collinsd@quicinc.com \
    --cc=quic_jprakash@quicinc.com \
    --cc=quic_subbaram@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®