Re: [PATCH V8 2/7] dt-bindings: mfd: pm8008: Add pm8008 regulator bindings

["Satya Priya Kakitapalli (Temp)" <quic_c_skakit@quicinc.com>]

On 3/25/2022 11:38 PM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-03-25 04:58:06)
>> Add bindings for pm8008 regulators device.
>>
>> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
>> ---
>> Changes in V8:
>>   - This is split from pm8008.yaml binding.
>>
>>   .../bindings/mfd/qcom,pm8008-regulators.yaml       | 87 ++++++++++++++++++++++
>>   1 file changed, 87 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8008-regulators.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008-regulators.yaml b/Documentation/devicetree/bindings/mfd/qcom,pm8008-regulators.yaml
>> new file mode 100644
>> index 0000000..139fbf9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008-regulators.yaml
>> @@ -0,0 +1,87 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/qcom,pm8008-regulators.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. PM8008 Regulator bindings
>> +
>> +maintainers:
>> +  - Satya Priya <quic_c_skakit@quicinc.com>
>> +
>> +description: |
>> +  Qualcomm Technologies, Inc. PM8008 is an I2C controlled PMIC
>> +  containing 7 LDO regulators. This binding specifies the PM8008
>> +  regulator peripherals of PM8008 device.
>> +
>> +properties:
>> +  compatible:
>> +    const: qcom,pm8008-regulators
>> +
>> +  reg:
>> +    description:
>> +      I2C slave address.
> Drop description? We know what it is.


okay


>> +
>> +    maxItems: 1
>> +
>> +  "#address-cells":
>> +    const: 0
>> +
>> +  "#size-cells":
>> +    const: 0
>> +
>> +  vdd_l1_l2-supply:
>> +    description: Input supply phandle of ldo1 and ldo2 regulators.
>> +
>> +  vdd_l3_l4-supply:
>> +    description: Input supply phandle of ldo3 and ldo4 regulators.
>> +
>> +  vdd_l5-supply:
>> +    description: Input supply phandle of ldo5 regulator.
>> +
>> +  vdd_l6-supply:
>> +    description: Input supply phandle of ldo6 regulator.
>> +
>> +  vdd_l7-supply:
>> +    description: Input supply phandle of ldo7 regulator.
>> +
>> +patternProperties:
>> +  "^ldo[1-7]$":
>> +    type: object
>> +    $ref: "../regulator/regulator.yaml#"
>> +    description: PM8008 regulator peripherals of PM8008 regulator device
>> +
>> +required:
>> +  - compatible
>> +  - "#address-cells"
>> +  - "#size-cells"
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/mfd/qcom-pm8008.h>
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    qupv3_se13_i2c {
> i2c
>
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +      pm8008_regulators: pmic@9 {
> Drop phandle please.


Okay.


>> +        compatible = "qcom,pm8008-regulators";
>> +        reg = <0x9>;
>> +        #address-cells = <0>;
>> +        #size-cells = <0>;
>> +
>> +        vdd_l1_l2-supply = <&vreg_s8b_1p2>;
>> +        vdd_l3_l4-supply = <&vreg_s1b_1p8>;
>> +        vdd_l5-supply = <&vreg_bob>;
>> +        vdd_l6-supply = <&vreg_bob>;
>> +        vdd_l7-supply = <&vreg_bob>;
>> +
>> +        pm8008_l1: ldo1 {
>> +          regulator-name = "pm8008_l1";
>> +          regulator-min-microvolt = <950000>;
>> +          regulator-max-microvolt = <1300000>;
>> +        };
>> +      };
>> +    };
>> +...
>> --
>> 2.7.4
>>