mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: Daniel Wagner <dwagner@suse.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>,
	Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH blktests v3 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code
Date: Tue, 29 Aug 2023 06:35:52 -0700	[thread overview]
Message-ID: <3b5b246f-386d-4afe-a20d-4b08770bd4cb@acm.org> (raw)
In-Reply-To: <ptqdqjo7xt5qsijmuftmboutck5bpwm2wjrwks5lr4l44ssvjy@iurtgbaxnoji>

On 8/28/23 19:11, Shinichiro Kawasaki wrote:
> This is the unclear point for me. Does bash really pass the arguments list of
> the caller to the callee when functions are called without arguments?
> 
> Looking back the commit 852996fea4f1, you explained that bash does, and I
> agreed. But now in my environment bash doesn't. I tried the script below in my
> environment, and see nothing printed.
> 
>    funcA() { echo "$1" ; }
>    funcB() { funcA; }
>    funcB foo
> 
> Then the arguments of funcB is not passed to funcA. How does it run in your
> environment?

I see the same result that you see. It seems that I misinterpret the 
text produced by shellcheck if it reports warning SC2119. After having 
reread https://github.com/koalaman/shellcheck/wiki/SC2119, I'm OK with
suppressing warning SC2119 because that warning doesn't seem useful to
me.

Thanks,

Bart.

  reply	other threads:[~2023-08-29 13:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22  8:38 [PATCH blktests v3 0/3] Introduce nvmet target setup/cleanup helpers Daniel Wagner
2023-08-22  8:38 ` [PATCH blktests v3 1/3] nvme/{033,034,035,036}: use default subsysnqn variable directly Daniel Wagner
2023-08-22  8:38 ` [PATCH blktests v3 2/3] nvme/{033,034,035,036,37}: drop port handle between passthru target setup and cleanup Daniel Wagner
2023-08-22  8:38 ` [PATCH blktests v3 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code Daniel Wagner
2023-08-24  3:09   ` Shinichiro Kawasaki
2023-08-24 14:36     ` Bart Van Assche
2023-08-25  0:53       ` Shinichiro Kawasaki
2023-08-25  6:40         ` Daniel Wagner
2023-08-25  7:34           ` Shinichiro Kawasaki
2023-08-25 11:29             ` Daniel Wagner
2023-08-25 13:45             ` Bart Van Assche
2023-08-25 14:26               ` Daniel Wagner
2023-08-25 16:46                 ` Bart Van Assche
2023-08-28  4:13                   ` Shinichiro Kawasaki
2023-08-28 15:14                     ` Bart Van Assche
2023-08-28 17:02                       ` Daniel Wagner
2023-08-28 18:55                         ` Bart Van Assche
2023-08-29  2:11                           ` Shinichiro Kawasaki
2023-08-29 13:35                             ` Bart Van Assche [this message]
2023-08-30  1:19                               ` Shinichiro Kawasaki
2023-09-01  0:33                                 ` Shinichiro Kawasaki
2023-08-25  6:24       ` Daniel Wagner
2023-08-28  4:17   ` Shinichiro Kawasaki
2023-08-28 15:14   ` Bart Van Assche
2023-08-28 17:03     ` Daniel Wagner
2023-08-22 17:54 ` [PATCH blktests v3 0/3] Introduce nvmet target setup/cleanup helpers Chaitanya Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b5b246f-386d-4afe-a20d-4b08770bd4cb@acm.org \
    --to=bvanassche@acm.org \
    --cc=dwagner@suse.de \
    --cc=hare@suse.de \
    --cc=jgg@ziepe.ca \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®