From: Bart Van Assche <bvanassche@acm.org>
To: Daniel Wagner <dwagner@suse.de>, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Chaitanya Kulkarni <kch@nvidia.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>,
Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH blktests v3 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code
Date: Mon, 28 Aug 2023 08:14:09 -0700 [thread overview]
Message-ID: <8e407992-d6da-46e2-a006-ad3b3cdfb101@acm.org> (raw)
In-Reply-To: <20230822083812.24612-4-dwagner@suse.de>
On 8/22/23 01:38, Daniel Wagner wrote:
> + while [[ $# -gt 0 ]]; do
> + case $1 in
> + --blkdev)
> + blkdev_type="$2"
> + shift 2
> + ;;
> + --ctrlkey)
> + ctrlkey="$2"
> + shift 2
> + ;;
> + --hostkey)
> + hostkey="$2"
> + shift 2
> + ;;
> + *)
> + shift
> + ;;
> + esac
> + done
So all arguments that are not recognized are ignored? That will
make debugging typo's harder than necessary. Shouldn't this function
complain if an unrecognized argument is encountered?
Thanks,
Bart.
next prev parent reply other threads:[~2023-08-28 15:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 8:38 [PATCH blktests v3 0/3] Introduce nvmet target setup/cleanup helpers Daniel Wagner
2023-08-22 8:38 ` [PATCH blktests v3 1/3] nvme/{033,034,035,036}: use default subsysnqn variable directly Daniel Wagner
2023-08-22 8:38 ` [PATCH blktests v3 2/3] nvme/{033,034,035,036,37}: drop port handle between passthru target setup and cleanup Daniel Wagner
2023-08-22 8:38 ` [PATCH blktests v3 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code Daniel Wagner
2023-08-24 3:09 ` Shinichiro Kawasaki
2023-08-24 14:36 ` Bart Van Assche
2023-08-25 0:53 ` Shinichiro Kawasaki
2023-08-25 6:40 ` Daniel Wagner
2023-08-25 7:34 ` Shinichiro Kawasaki
2023-08-25 11:29 ` Daniel Wagner
2023-08-25 13:45 ` Bart Van Assche
2023-08-25 14:26 ` Daniel Wagner
2023-08-25 16:46 ` Bart Van Assche
2023-08-28 4:13 ` Shinichiro Kawasaki
2023-08-28 15:14 ` Bart Van Assche
2023-08-28 17:02 ` Daniel Wagner
2023-08-28 18:55 ` Bart Van Assche
2023-08-29 2:11 ` Shinichiro Kawasaki
2023-08-29 13:35 ` Bart Van Assche
2023-08-30 1:19 ` Shinichiro Kawasaki
2023-09-01 0:33 ` Shinichiro Kawasaki
2023-08-25 6:24 ` Daniel Wagner
2023-08-28 4:17 ` Shinichiro Kawasaki
2023-08-28 15:14 ` Bart Van Assche [this message]
2023-08-28 17:03 ` Daniel Wagner
2023-08-22 17:54 ` [PATCH blktests v3 0/3] Introduce nvmet target setup/cleanup helpers Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e407992-d6da-46e2-a006-ad3b3cdfb101@acm.org \
--to=bvanassche@acm.org \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=jgg@ziepe.ca \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®