From: Changwoo Min <changwoo@igalia.com>
To: Tejun Heo <tj@kernel.org>
Cc: void@manifault.com, arighi@nvidia.com, kernel-dev@igalia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] sched_ext: Add an event, SCX_EVENT_RQ_BYPASSING_OPS
Date: Fri, 17 Jan 2025 16:31:55 +0900 [thread overview]
Message-ID: <3b7880c6-2de2-4e68-b247-8c4ace4fc92b@igalia.com> (raw)
In-Reply-To: <Z4m1XqHl4whTG1pl@slm.duckdns.org>
Hello,
On 25. 1. 17. 10:41, Tejun Heo wrote:
>> +
>> + /*
>> + * When the bypassing mode is set, the number of bypassed operations.
>> + */
>> + u64 RQ_BYPASSING_OPS;
>> };
>
> I'm not sure this is a particularly good way to account for bypass mode.
> Maybe account the total duration of bypass modes,the number of times it was
> activated and the number of times tasks were dispatched in bypass mode?
I think it is a good idea to further specialize RQ_BYPASSING events.
For the number of times the bypassing mode activated, what about
BYPASS_NR_ACTIVATED?
For the number of task dispatched,what about
BYPASS_NR_TASK_DISPATCHED?
I think BYPASS_NR_ACTIVATED and BYPASS_NR_TASK_DISPATCHED will be
a good proxy for the total duration, so we can skip it until we
have a clear user case. If we need the total duration now (maybe
BYPASS_DURATION?), we can directly measure it in the
scx_ops_bypass() directly. What do you think?
Regards,
Changwoo Min
next prev parent reply other threads:[~2025-01-17 7:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 15:15 [PATCH 0/7] sched_ext: Implement core event counters Changwoo Min
2025-01-16 15:15 ` [PATCH 1/7] sched_ext: Implement event counter infrastructure and add an event Changwoo Min
2025-01-17 1:33 ` Tejun Heo
2025-01-17 7:08 ` Changwoo Min
2025-01-17 16:24 ` Tejun Heo
2025-01-18 0:27 ` Changwoo Min
2025-01-22 0:42 ` Tejun Heo
2025-01-22 1:37 ` Changwoo Min
2025-01-17 9:49 ` Andrea Righi
2025-01-17 16:26 ` Tejun Heo
2025-01-18 0:00 ` Changwoo Min
2025-01-21 15:00 ` Leonardo Temperanza
2025-01-22 1:45 ` Changwoo Min
2025-01-16 15:15 ` [PATCH 2/7] sched_ext: Add an event, SCX_EVENT_OFFLINE_LOCAL_DSQ Changwoo Min
2025-01-17 1:37 ` Tejun Heo
2025-01-17 7:11 ` Changwoo Min
2025-01-16 15:15 ` [PATCH 3/7] sched_ext: Add an event, SCX_EVENT_CNTD_RUN_WO_ENQ Changwoo Min
2025-01-17 1:39 ` Tejun Heo
2025-01-17 7:12 ` Changwoo Min
2025-01-16 15:15 ` [PATCH 4/7] sched_ext: Add an event, SCX_EVENT_ENQ_LOCAL_EXITING Changwoo Min
2025-01-17 1:40 ` Tejun Heo
2025-01-17 7:12 ` Changwoo Min
2025-01-16 15:15 ` [PATCH 5/7] sched_ext: Add an event, SCX_EVENT_RQ_BYPASSING_OPS Changwoo Min
2025-01-17 1:41 ` Tejun Heo
2025-01-17 7:31 ` Changwoo Min [this message]
2025-01-17 16:14 ` Tejun Heo
2025-01-16 15:15 ` [PATCH 6/7] sched_ext: Add scx_bpf_event_stat() and scx_read_event() for BPF schedulers Changwoo Min
2025-01-16 15:15 ` [PATCH 7/7] sched_ext: Print core event count in scx_central scheduler Changwoo Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b7880c6-2de2-4e68-b247-8c4ace4fc92b@igalia.com \
--to=changwoo@igalia.com \
--cc=arighi@nvidia.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®