* [PATCH v2] f2fs: compress: disallow disabling compress on non-empty compressed file [not found] <CGME20211027041606epcas1p237acb5e258066f2298f3fee162baffe4@epcas1p2.samsung.com> @ 2021-10-27 4:16 ` Hyeong-Jun Kim 2021-10-27 4:26 ` Chao Yu 0 siblings, 1 reply; 2+ messages in thread From: Hyeong-Jun Kim @ 2021-10-27 4:16 UTC (permalink / raw) To: Jaegeuk Kim, Chao Yu Cc: Hyeong-Jun Kim, Sungjong Seo, linux-f2fs-devel, linux-kernel Compresse file and normal file has differ in i_addr addressing, specifically addrs per inode/block. So, we will face data loss, if we disable the compression flag on non-empty files. Therefore we should disallow not only enabling but disabling the compression flag on non-empty files. --- v2: - check F2FS_HAS_BLOCKS() instead of i_size Fixes: 4c8ff7095bef ("f2fs: support data compression") Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> Signed-off-by: Hyeong-Jun Kim <hj514.kim@samsung.com> --- fs/f2fs/f2fs.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index b8e8f8c716b0..23b437dc7d65 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4177,8 +4177,7 @@ static inline bool f2fs_disable_compressed_file(struct inode *inode) if (!f2fs_compressed_file(inode)) return true; - if (S_ISREG(inode->i_mode) && - (get_dirty_pages(inode) || atomic_read(&fi->i_compr_blocks))) + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode)) return false; fi->i_flags &= ~F2FS_COMPR_FL; -- 2.25.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] f2fs: compress: disallow disabling compress on non-empty compressed file 2021-10-27 4:16 ` [PATCH v2] f2fs: compress: disallow disabling compress on non-empty compressed file Hyeong-Jun Kim @ 2021-10-27 4:26 ` Chao Yu 0 siblings, 0 replies; 2+ messages in thread From: Chao Yu @ 2021-10-27 4:26 UTC (permalink / raw) To: Hyeong-Jun Kim, Jaegeuk Kim; +Cc: Sungjong Seo, linux-f2fs-devel, linux-kernel On 2021/10/27 12:16, Hyeong-Jun Kim wrote: > Compresse file and normal file has differ in i_addr addressing, > specifically addrs per inode/block. So, we will face data loss, if we > disable the compression flag on non-empty files. Therefore we should > disallow not only enabling but disabling the compression flag on > non-empty files. > > --- > v2: > - check F2FS_HAS_BLOCKS() instead of i_size > > Fixes: 4c8ff7095bef ("f2fs: support data compression") > Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> > Signed-off-by: Hyeong-Jun Kim <hj514.kim@samsung.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks, ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-27 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20211027041606epcas1p237acb5e258066f2298f3fee162baffe4@epcas1p2.samsung.com>
2021-10-27 4:16 ` [PATCH v2] f2fs: compress: disallow disabling compress on non-empty compressed file Hyeong-Jun Kim
2021-10-27 4:26 ` Chao Yu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®