From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: chuguangqing <chuguangqing@inspur.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<intel-wired-lan@lists.osuosl.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Subject: Re: [PATCH 1/1] check the ioremap return value first (supplementary CC)
Date: Mon, 23 Jun 2025 10:45:34 +0200 [thread overview]
Message-ID: <3bf6df3b-affe-4f10-8b05-29f3393d19e0@intel.com> (raw)
In-Reply-To: <20250619124921.44677-1-chuguangqing@inspur.com>
On 6/19/25 14:48, chuguangqing wrote:
> tks to pabeni.
> cc the relevant ML in the email.
>
Thank you for reaching out with the patch, it is an attempt to
fix something observable?
I have found the original topic via web search [1]. It looks that the
proposed patch does not change anything - adapter->io_addr was null
also before the assignment, so it does not hurt as-is. And the check
afterwards is equally effective for me to prevent subsequent
dereference.
[1] https://lkml.org/lkml/2025/6/19/343
next prev parent reply other threads:[~2025-06-23 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250618092544.53696-1-chuguangqing@inspur.com>
2025-06-19 7:11 ` [PATCH 0/1] " chuguangqing
2025-06-19 7:11 ` [PATCH 1/1] ixgbe: " chuguangqing
2025-06-19 7:29 ` Paolo Abeni
2025-06-19 12:48 ` Re: [PATCH 1/1] " chuguangqing
2025-06-23 8:45 ` Przemek Kitszel [this message]
2025-06-24 2:58 ` chuguangqing
2025-06-24 2:58 ` [PATCH 0/1] " chuguangqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bf6df3b-affe-4f10-8b05-29f3393d19e0@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=chuguangqing@inspur.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®