[PATCH 0/1] check the ioremap return value first (supplementary CC)

[PATCH 0/1] check the ioremap return value first (supplementary CC)

[chuguangqing]

Always check ioremap() return value  before use.

chuguangqing (1):
  ixgbe: check the ioremap return value first

 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.43.5

[PATCH 1/1] ixgbe: check the ioremap return value first (supplementary CC)

[chuguangqing]

We should first check whether the ioremap return value is NULL before using it.

Signed-off-by: chuguangqing <chuguangqing@inspur.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 6eccfba51fac..97a49463b09d 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -11431,11 +11431,11 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	hw->hw_addr = ioremap(pci_resource_start(pdev, 0),
 			      pci_resource_len(pdev, 0));
-	adapter->io_addr = hw->hw_addr;
 	if (!hw->hw_addr) {
 		err = -EIO;
 		goto err_ioremap;
 	}
+	adapter->io_addr = hw->hw_addr;
 
 	/* Setup hw api */
 	hw->mac.ops   = *ii->mac_ops;
-- 
2.43.5

Re: [PATCH 1/1] ixgbe: check the ioremap return value first (supplementary CC)

[Paolo Abeni]

On 6/19/25 9:11 AM, chuguangqing wrote:
> We should first check whether the ioremap return value is NULL before using it.
> 
> Signed-off-by: chuguangqing <chuguangqing@inspur.com>

You are not CC-ing any of the relevant ML (netdev@vger.kernel.org -
intel-wired-lan@lists.osuosl.org): this patch will be lost.

/P

Re: Re: [PATCH 1/1] check the ioremap return value first (supplementary CC)

[chuguangqing]

 tks to pabeni. 
 cc the relevant ML in the email.

Re: [PATCH 1/1] check the ioremap return value first (supplementary CC)

[Przemek Kitszel]

On 6/19/25 14:48, chuguangqing wrote:
>   tks to pabeni.
>   cc the relevant ML in the email.
> 

Thank you for reaching out with the patch, it is an attempt to
fix something observable?

I have found the original topic via web search [1]. It looks that the
proposed patch does not change anything - adapter->io_addr was null
also before the assignment, so it does not hurt as-is. And the check
afterwards is equally effective for me to prevent subsequent
dereference.

[1] https://lkml.org/lkml/2025/6/19/343

Re: Re: [PATCH 1/1] check the ioremap return value first (supplementary CC)

[chuguangqing]

First of all, thank you for your reply. Yes, this patch doesn't change anything substantial. It's merely for demonstrating good programming practices, so you can decide whether to apply it or not.

[PATCH 0/1] check the ioremap return value first (supplementary CC)

[chuguangqing]

Always check ioremap() return value  before use.

chuguangqing (1):
  ixgbe: check the ioremap return value first

 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.43.5