From: "WeitaoWang-oc@zhaoxin.com" <WeitaoWang-oc@zhaoxin.com>
To: <mathias.nyman@intel.com>, <gregkh@linuxfoundation.org>,
<stern@rowland.harvard.edu>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <CobeChen@zhaoxin.com>, <TimGuo@zhaoxin.com>,
<tonywwang@zhaoxin.com>, <weitaowang@zhaoxin.com>
Subject: [PATCH] USB: Fix xhci ERDP update issue
Date: Mon, 14 Mar 2022 15:25:23 +0800 [thread overview]
Message-ID: <3c576edf-89c3-ccf3-a43f-4ce2c1ced18d@zhaoxin.com> (raw)
On some situations, software handles TRB events slower than adding TRBs,
xhci_irq will not exit until all events are handled. If xhci_irq just
handles 256 TRBs and exit, the temp variable(event_ring_deq) driver
records in xhci irq is equal to driver current dequeue pointer. It will
cause driver not update ERDP and software dequeue pointer lost sync with
ERDP. On the next xhci_irq, the event ring is full but driver will not
update ERDP as software dequeue pointer is equal to ERDP.
[ 536.377115] xhci_hcd 0000:00:12.0: ERROR unknown event type 37
[ 566.933173] sd 8:0:0:0: [sdb] tag#27 uas_eh_abort_handler 0 uas-tag 7
inflight: CMD OUT
[ 566.933181] sd 8:0:0:0: [sdb] tag#27 CDB: Write(10) 2a 00 17 71 e6 78
00 00 08 00
[ 572.041186] xhci_hcd On some situataions,the0000:00:12.0: xHCI host
not responding to stop endpoint command.
[ 572.057193] xhci_hcd 0000:00:12.0: Host halt failed, -110
[ 572.057196] xhci_hcd 0000:00:12.0: xHCI host controller not
responding, assume dead
[ 572.057236] sd 8:0:0:0: [sdb] tag#26 uas_eh_abort_handler 0 uas-tag 6
inflight: CMD
[ 572.057240] sd 8:0:0:0: [sdb] tag#26 CDB: Write(10) 2a 00 38 eb cc d8
00 00 08 00
[ 572.057244] sd 8:0:0:0: [sdb] tag#25 uas_eh_abort_handler 0 uas-tag 5
inflight: CMD
Fixed this issue by update software record temp variable when handles
128 TRB events.
Signed-off-by: Weitao Wang <WeitaoWang-oc@zhaoxin.com>
---
drivers/usb/host/xhci-ring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index d0b6806..f970799 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -3141,6 +3141,7 @@ irqreturn_t xhci_irq(struct usb_hcd *hcd)
if (event_loop++ < TRBS_PER_SEGMENT / 2)
continue;
xhci_update_erst_dequeue(xhci, event_ring_deq);
+ event_ring_deq = xhci->event_ring->dequeue;
/* ring is half-full, force isoc trbs to interrupt more
often */
if (xhci->isoc_bei_interval > AVOID_BEI_INTERVAL_MIN)
--
2.7.4
next reply other threads:[~2022-03-14 7:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 7:25 WeitaoWang-oc [this message]
2022-03-14 7:39 ` Greg KH
2022-03-16 11:57 ` Peter Chen
2022-03-16 12:45 ` Mathias Nyman
2022-03-17 1:51 ` Peter Chen
2022-03-16 12:47 ` WeitaoWang-oc
2022-03-15 8:08 ` Mathias Nyman
2022-03-15 12:44 ` WeitaoWang-oc
2022-03-16 13:20 ` Mathias Nyman
2022-03-17 2:43 ` WeitaoWang-oc
2022-03-17 1:56 ` Peter Chen
2022-03-18 7:32 WeitaoWang-oc
2022-03-18 7:45 ` Greg KH
2022-03-18 12:17 WeitaoWang-oc
2022-03-18 12:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c576edf-89c3-ccf3-a43f-4ce2c1ced18d@zhaoxin.com \
--to=weitaowang-oc@zhaoxin.com \
--cc=CobeChen@zhaoxin.com \
--cc=TimGuo@zhaoxin.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tonywwang@zhaoxin.com \
--cc=weitaowang@zhaoxin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®