From: Tim Jiang <quic_tjiang@quicinc.com>
To: Johan Hovold <johan@kernel.org>
Cc: <marcel@holtmann.org>, <linux-kernel@vger.kernel.org>,
<linux-bluetooth@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <quic_bgodavar@quicinc.com>,
<quic_hemantg@quicinc.com>
Subject: Re: [PATCH v12 1/2] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066
Date: Thu, 27 Jul 2023 12:34:58 +0800 [thread overview]
Message-ID: <3c590f6f-bb57-b932-b746-8a189bac332c@quicinc.com> (raw)
In-Reply-To: <ZMDETVMUmJxmbIvW@hovoldconsulting.com>
Hi Johan:
I will address your comments in v13 version.
regards
On 7/26/23 14:59, Johan Hovold wrote:
> Please fix up the subject of this patch, which should be different from
> patch 2/2 and instead summarise what *this* patch does.
>
> Note that keeping the same 2/2 subject on the cover letter is fine as
> 2/2 is the primary patch and sort of summarises the series.
>
> On Wed, Jul 26, 2023 at 01:22:44PM +0800, Tim Jiang wrote:
>> This patch make the print btsoc type expression more clearly.
>>
>> Signed-off-by: Tim Jiang <quic_tjiang@quicinc.com>
>> ---
>> drivers/bluetooth/btqca.h | 1 +
>> drivers/bluetooth/hci_qca.c | 34 ++++++++++++++++++++++++++++++----
>> 2 files changed, 31 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h
>> index b884095bcd9d..529382f0abb1 100644
>> --- a/drivers/bluetooth/btqca.h
>> +++ b/drivers/bluetooth/btqca.h
>> @@ -148,6 +148,7 @@ enum qca_btsoc_type {
>> QCA_QCA6390,
>> QCA_WCN6750,
>> QCA_WCN6855,
>> + QCA_QCA2066,
> This belongs in the next patch.
>
> These are currently not sorted by probably should be to make it easier
> to look up and add new entries. This could be done in a third,
> preparatory, patch.
>
>> };
>>
>> #if IS_ENABLED(CONFIG_BT_QCA)
>> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> index 9b785c947d96..453000df7aec 100644
>> --- a/drivers/bluetooth/hci_qca.c
>> +++ b/drivers/bluetooth/hci_qca.c
>> @@ -1748,6 +1748,7 @@ static int qca_setup(struct hci_uart *hu)
>> const char *firmware_name = qca_get_firmware_name(hu);
>> int ret;
>> struct qca_btsoc_version ver;
>> + const char *soc_name;
>>
>> ret = qca_check_speeds(hu);
>> if (ret)
>> @@ -1762,10 +1763,35 @@ static int qca_setup(struct hci_uart *hu)
>> */
>> set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
>>
>> - bt_dev_info(hdev, "setting up %s",
>> - qca_is_wcn399x(soc_type) ? "wcn399x" :
>> - (soc_type == QCA_WCN6750) ? "wcn6750" :
>> - (soc_type == QCA_WCN6855) ? "wcn6855" : "ROME/QCA6390");
>> + switch (soc_type) {
>> + case QCA_AR3002:
>> + soc_name = "ar300x";
>> + break;
>> + case QCA_ROME:
>> + soc_name = "ROME";
>> + break;
>> + case QCA_WCN3990:
>> + case QCA_WCN3991:
>> + case QCA_WCN3998:
>> + soc_name = "wcn399x";
>> + break;
>> + case QCA_QCA2066:
>> + soc_name = "QCA2066";
>> + break;
> This also belongs in the next patch.
>
>> + case QCA_QCA6390:
>> + soc_name = "QCA6390";
>> + break;
>> + case QCA_WCN6750:
>> + soc_name = "wcn6750";
>> + break;
>> + case QCA_WCN6855:
>> + soc_name = "wcn6855";
>> + break;
>> + default:
>> + soc_name = "unknown soc";
>> + break;
>> + }
> And you should probably sort the above as well.
>
>> + bt_dev_info(hdev, "setting up %s", soc_name);
>>
>> qca->memdump_state = QCA_MEMDUMP_IDLE;
> Johan
next prev parent reply other threads:[~2023-07-27 4:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 5:22 [PATCH v12 0/2] " Tim Jiang
2023-07-26 5:22 ` [PATCH v12 1/2] " Tim Jiang
2023-07-26 6:59 ` Johan Hovold
2023-07-27 4:34 ` Tim Jiang [this message]
2023-07-26 5:22 ` [PATCH v12 2/2] " Tim Jiang
2023-07-26 7:07 ` Johan Hovold
2023-07-26 7:03 ` [PATCH v12 0/2] " Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c590f6f-bb57-b932-b746-8a189bac332c@quicinc.com \
--to=quic_tjiang@quicinc.com \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_hemantg@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®