From: Johan Hovold <johan@kernel.org>
To: Tim Jiang <quic_tjiang@quicinc.com>
Cc: marcel@holtmann.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org,
quic_bgodavar@quicinc.com, quic_hemantg@quicinc.com
Subject: Re: [PATCH v12 0/2] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066
Date: Wed, 26 Jul 2023 09:03:10 +0200 [thread overview]
Message-ID: <ZMDFLl1iAHrcQkt_@hovoldconsulting.com> (raw)
In-Reply-To: <20230726052245.609987-1-quic_tjiang@quicinc.com>
On Wed, Jul 26, 2023 at 01:22:43PM +0800, Tim Jiang wrote:
Thanks for adding the changelog.
You should also add a sentence or two here that describes what the
series does (e.g. just say "This series adds support for ...").
Also make sure to run scripts/get_maintainer.pl on your series. Looks
like you're still missing some maintainers on CC.
You also did not CC at least on person providing review feedback on
earlier versions.
> Changes in v12
> - fix compile error issue for patch 1/2
>
> Changes in v11
> - reverse two patches order
>
> Changes in v10
> - break out btsoc type print into seperate patch
>
> Changes in v2-v9
> - solve review comments for code style and commit message context
This is not detailed enough for a changelog, but ok, let's forget about
v2-v9 this time, but remember it for your future submissions.
> Tim Jiang (2):
> Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066
> Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066
As I mentioned elsewhere, these Subjects should be distinct and
summarise what each patch does.
Johan
prev parent reply other threads:[~2023-07-26 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 5:22 Tim Jiang
2023-07-26 5:22 ` [PATCH v12 1/2] " Tim Jiang
2023-07-26 6:59 ` Johan Hovold
2023-07-27 4:34 ` Tim Jiang
2023-07-26 5:22 ` [PATCH v12 2/2] " Tim Jiang
2023-07-26 7:07 ` Johan Hovold
2023-07-26 7:03 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMDFLl1iAHrcQkt_@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=quic_bgodavar@quicinc.com \
--cc=quic_hemantg@quicinc.com \
--cc=quic_tjiang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®