From: Anoob Soman <anoob.soman@citrix.com>
To: Juergen Gross <jgross@suse.com>, <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>
Cc: <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] xen-evtchn: Bind dyn evtchn:qemu-dm interrupt to next online VCPU
Date: Mon, 5 Jun 2017 10:54:40 +0100 [thread overview]
Message-ID: <3c5989b7-c5b4-6602-5b09-46277860653e@citrix.com> (raw)
In-Reply-To: <a75010da-0e62-5153-2dd2-2069a3c5f54f@suse.com>
On 02/06/17 16:10, Juergen Gross wrote:
>
> I'd prefer the to have irq disabled from taking the lock until here.
> This will avoid problems due to preemption and will be faster as it
> avoids one irq on/off cycle. So:
>
> local_irq_disable();
> raw_spin_lock();
> ...
> raw_spin_unlock();
> this_cpu_write();
> xen_rebind_evtchn_to_cpu();
> local_irq_enable();
>
>
> Juergen
Agreed, I will send a V2 with your suggestion.
-Anoob.
next prev parent reply other threads:[~2017-06-05 9:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 14:49 Anoob Soman
2017-06-02 15:10 ` Juergen Gross
2017-06-05 9:54 ` Anoob Soman [this message]
2017-06-02 16:24 ` Boris Ostrovsky
2017-06-05 10:14 ` Anoob Soman
2017-06-05 14:10 ` Boris Ostrovsky
2017-06-05 14:49 ` [Xen-devel] " Anoob Soman
2017-06-05 15:32 ` Boris Ostrovsky
2017-06-05 16:14 ` Anoob Soman
2017-06-05 16:46 ` Boris Ostrovsky
2017-06-05 17:13 ` Anoob Soman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c5989b7-c5b4-6602-5b09-46277860653e@citrix.com \
--to=anoob.soman@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®