mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Yijie Yang <quic_yijiyang@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: Enable ethernet node
Date: Fri, 22 Nov 2024 14:19:41 +0100	[thread overview]
Message-ID: <3c69423e-ba80-487f-b585-1e4ffb4137b6@lunn.ch> (raw)
In-Reply-To: <c2800557-225d-4fbd-83ee-d4b72eb587ce@oss.qualcomm.com>

> >>>   +&ethernet {
> >>> +    status = "okay";
> >>> +
> >>> +    pinctrl-0 = <&ethernet_defaults>;
> >>> +    pinctrl-names = "default";
> >>> +
> >>> +    phy-handle = <&rgmii_phy>;
> >>> +    phy-mode = "rgmii";
> >>
> >> That is unusual. Does the board have extra long clock lines?
> > 
> > Do you mean to imply that using RGMII mode is unusual? While the EMAC controller supports various modes, due to hardware design limitations, only RGMII mode can be effectively implemented.
> 
> Is that a board-specific issue, or something that concerns the SoC itself?

Lots of developers gets this wrong.... Searching the mainline list for
patchs getting it wrong and the explanation i have given in the past
might help.

The usual setting here is 'rgmmii-id', which means something needs to
insert a 2ns delay on the clock lines. This is not always true, a very
small number of boards use extra long clock likes on the PCB to add
the needed 2ns delay.

Now, if 'rgmii' does work, it means something else is broken
somewhere. I will let you find out what.

> >>> +    max-speed = <1000>;
> >>
> >> Why do you have this property? It is normally used to slow the MAC
> >> down because of issues at higher speeds.
> > 
> > According to the databoot, the EMAC in RGMII mode can support speeds of up to 1Gbps.
> 
> I believe the question Andrew is asking is "how is that effectively
> different from the default setting (omitting the property)?"

Correct. If there are no issues at higher speeds, you don't need
this. phylib will ask the PHY what it is capable of, and limit the
negotiated speeds to its capabilities. Occasionally you do see an
RGMII PHY connected to a MII MAC, because a RGMII PHY is cheaper...

	Andrew

  reply	other threads:[~2024-11-22 13:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18  6:44 [PATCH v2 0/2] Enable ethernet on qcs615 Yijie Yang
2024-11-18  6:44 ` [PATCH v2 1/2] arm64: dts: qcom: qcs615: add ethernet node Yijie Yang
2024-11-18  6:44 ` [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: Enable " Yijie Yang
2024-11-19  1:27   ` Andrew Lunn
2024-11-19 10:09     ` Yijie Yang
2024-11-22 12:27       ` Konrad Dybcio
2024-11-22 13:19         ` Andrew Lunn [this message]
2024-11-27  6:17           ` Yijie Yang
2024-11-27  7:00             ` Yijie Yang
2024-11-29 15:29               ` Andrew Lunn
2024-12-09  2:11                 ` Yijie Yang
2024-12-09  3:13                   ` Andrew Lunn
2024-12-10  3:29                     ` Yijie Yang
2024-12-10  4:09                       ` Andrew Lunn
2024-12-16  6:56                         ` Yijie Yang
2024-12-16  9:18                           ` Andrew Lunn
2024-12-17  2:26                             ` Yijie Yang
2024-12-17 10:18                               ` Andrew Lunn
2024-12-18  7:25                                 ` Yijie Yang
2024-12-18 16:57                                   ` Andrew Lunn
2024-11-29 15:15             ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c69423e-ba80-487f-b585-1e4ffb4137b6@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=quic_yijiyang@quicinc.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®