mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yijie Yang <quic_yijiyang@quicinc.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: Enable ethernet node
Date: Wed, 18 Dec 2024 15:25:22 +0800	[thread overview]
Message-ID: <aa1dcdf6-94a0-4922-83f0-3cf49516ac4f@quicinc.com> (raw)
In-Reply-To: <8acf4557-ac10-43f1-b1ab-7ae63f64401f@lunn.ch>



On 2024-12-17 18:18, Andrew Lunn wrote:
> On Tue, Dec 17, 2024 at 10:26:15AM +0800, Yijie Yang wrote:
>>
>>
>> On 2024-12-16 17:18, Andrew Lunn wrote:
>>>> I intend to follow these steps. Could you please check if they are correct?
>>>> 1. Add a new flag in DTS to inform the MAC driver to include the delay when
>>>> configured with 'rgmii-id'. Without this flag, the MAC driver will not be
>>>> aware of the need for the delay.
>>>
>>> Why do you need this flag?
>>>
>>> If the phy-mode is rgmii-id, either the MAC or the PHY needs to add
>>> the delay.
>>>
>>> The MAC driver gets to see phy-mode first. If it wants to add the
>>> delay, it can, but it needs to mask out the delays before passing
>>> phy-mode to the PHY. If the MAC driver does not want to add the
>>> delays, pass phy-mode as is the PHY, and it will add the delays.
>>
>> In this scenario, the delay in 'rgmii-id' mode is currently introduced by
>> the MAC as it is fixed in the driver code. How can we enable the PHY to add
>> the delay in this mode in the future (If we intend to revert to the most
>> common approach of the Linux kernel)? After all, the MAC driver is unsure
>> when to add the delay.
> 
> You just take out the code in the MAC driver which adds the delay and
> masks the phy-mode. 2ns should be 2ns delay, independent of who
> inserts it. The only danger is, there might be some board uses a PHY
> which is incapable of adding the 2ns delay, and such a change breaks
> that board.

Okay, I will follow your instructions:
1. Change the phy-mode to 'rgmii-id'.
2. Add the delay in the MAC driver.
3. Mask the phy-mode before passing it to the PHY.

> 
> But i assume Qualcomm RDKs always make use of a Qualcomm PHY, there is
> special pricing if you use the combination, so there is probably
> little incentive to use somebody elses PHY. And i assume you can
> quickly check all Qualcomm PHYs support RGMII delays. PHYs which don't
> support RGMII delays are very rare, it just happened that one vendors
> RDK happened to use one, so they ended up with delays in the MAC being
> standard for their boards.
> 

Most Qualcomm MAC applications are actually paired with a third-party 
PHY. I agree that the original author's PHY might not support adding the 
delay. However, this assumption cannot be verified since the initial 
code was uploaded from the internal code base.

> 	Andrew
> 

-- 
Best Regards,
Yijie


  reply	other threads:[~2024-12-18  7:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18  6:44 [PATCH v2 0/2] Enable ethernet on qcs615 Yijie Yang
2024-11-18  6:44 ` [PATCH v2 1/2] arm64: dts: qcom: qcs615: add ethernet node Yijie Yang
2024-11-18  6:44 ` [PATCH v2 2/2] arm64: dts: qcom: qcs615-ride: Enable " Yijie Yang
2024-11-19  1:27   ` Andrew Lunn
2024-11-19 10:09     ` Yijie Yang
2024-11-22 12:27       ` Konrad Dybcio
2024-11-22 13:19         ` Andrew Lunn
2024-11-27  6:17           ` Yijie Yang
2024-11-27  7:00             ` Yijie Yang
2024-11-29 15:29               ` Andrew Lunn
2024-12-09  2:11                 ` Yijie Yang
2024-12-09  3:13                   ` Andrew Lunn
2024-12-10  3:29                     ` Yijie Yang
2024-12-10  4:09                       ` Andrew Lunn
2024-12-16  6:56                         ` Yijie Yang
2024-12-16  9:18                           ` Andrew Lunn
2024-12-17  2:26                             ` Yijie Yang
2024-12-17 10:18                               ` Andrew Lunn
2024-12-18  7:25                                 ` Yijie Yang [this message]
2024-12-18 16:57                                   ` Andrew Lunn
2024-11-29 15:15             ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa1dcdf6-94a0-4922-83f0-3cf49516ac4f@quicinc.com \
    --to=quic_yijiyang@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®